Remove test configurations in tests/resources - #212
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 85.41% 87.79% +2.37%
==========================================
Files 22 22
Lines 1303 1303
==========================================
+ Hits 1113 1144 +31
+ Misses 190 159 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3a0fc0 to
9595035
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Thanks for implementing this @Qian-HuiChen. It is nice to see so many deleted files :)
As the cloned configurations are used in several tests, an option could be to have a session-scoped fixture that creates a cache of the cloned configurations. Then a test-scoped fixture that copies the clone to a tmp directory, and then cleans up the directory after. This might run faster than cloning for every test.
3012e8c to
7a19ac6
Compare
There was a problem hiding this comment.
The fixture implementation looks neat! The latest commit does speed up the tests :) On my local laptop, the tests in 9595035 took about 90s to run and now in 7a19ac6, its about 45s
Both my comments on code are minor and can be left, but it would good to reduce the size of the test esm1.6's access.out file if possible, as it's a large file to add to the repository.
7a19ac6 to
7afe6ef
Compare
|
I tried to trim down |
jo-basevi
left a comment
There was a problem hiding this comment.
Thanks @Qian-HuiChen, looks good to me :)
Remove all configurations stored in
tests/resourceswhich are used in unit testing.Instead, on-demand cloning is called via
git cloneduring unit test execution and cleaned up after the unit tests. A fixed commit hash is currently hard-coded intests/common.pyto ensure reproducibility and version control.Closes #117.