Add sync:base_path check in QA test.#214
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 85.38% 85.41% +0.03%
==========================================
Files 22 22
Lines 1300 1303 +3
==========================================
+ Hits 1110 1113 +3
Misses 190 190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qian-HuiChen
force-pushed
the
213-base-path-test
branch
from
b401e65 to
b9c19cc
Compare
atteggiani
reviewed
May 4, 2026
Contributor
There was a problem hiding this comment.
This looks good @Qian-HuiChen
Just a small simplification
Qian-HuiChen
force-pushed
the
213-base-path-test
branch
from
1c14b56 to
5e851b3
Compare
atteggiani
approved these changes
May 4, 2026
Comment on lines
+235
to
+239
| def test_sync_path_is_none(self, config): | ||
| if "sync" in config and "path" in config["sync"]: | ||
| assert ( | ||
| config["sync"]["path"] is None | ||
| ), "Sync paths should be None if it is set" |
Member
There was a problem hiding this comment.
We now prefer to use base_path, so I think the test should not allow config["sync"]["path"] at all, because we do not want to suggest to users that this is the preferred option.
Sorry for commenting on a closed PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the QA test to check
base_pathis not set in sync in config.yaml, instead of checkingpath.Closes #213.