Skip to content

Add QA checks on ESM1.6 metadata fields. - #222

Merged
Qian-HuiChen merged 2 commits into
mainfrom
221-release-esm1p6-qa
May 25, 2026
Merged

Add QA checks on ESM1.6 metadata fields.#222
Qian-HuiChen merged 2 commits into
mainfrom
221-release-esm1p6-qa

Conversation

@Qian-HuiChen

@Qian-HuiChen Qian-HuiChen commented May 20, 2026

Copy link
Copy Markdown
Contributor

This PR add QA checks on metadata fields in ESM1.6 config repository, including:

Closes #221 .

@Qian-HuiChen

Copy link
Copy Markdown
Contributor Author

Tests (test_test_access_esm1p6_config_release_release_preindustrial) needs to be re-run after ESM1.6 metadata is updated (see file).

Comment thread src/model_config_tests/config_tests/qa/test_access_esm1p6_config.py Outdated
Comment thread src/model_config_tests/config_tests/qa/test_access_esm1p6_config.py Outdated
@anton-seaice

Copy link
Copy Markdown
Contributor

The content of this change looks fine. I don't really think doing CI tests (of tests) using the real configs is a good idea (as they can't ever pass when a requirement changes, and there's no independence between tests & config) but that is largely related to this issue !

Comment thread tests/common.py
Comment thread tests/common.py
Comment thread tests/common.py
Comment thread tests/config_tests/qa/test_test_access_esm1p6_config.py
@codecov

codecov Bot commented May 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (8e69cc4) to head (5ba476e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   87.72%   90.06%   +2.34%     
==========================================
  Files          22       22              
  Lines        1303     1308       +5     
==========================================
+ Hits         1143     1178      +35     
+ Misses        160      130      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aidanheerdegen aidanheerdegen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qian-HuiChen
Qian-HuiChen merged commit ebff37d into main May 25, 2026
8 checks passed
@Qian-HuiChen
Qian-HuiChen deleted the 221-release-esm1p6-qa branch May 25, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACCESS-ESM1.6 metadata QA checks

5 participants