-
Notifications
You must be signed in to change notification settings - Fork 0
Extract duplicated CI setup steps into composite action #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: jreakin <[email protected]>
Co-authored-by: jreakin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR successfully refactors the CI workflow by extracting duplicated setup steps into a reusable composite action, reducing code duplication and improving maintainability.
Key Changes:
- Created a composite action that consolidates repository checkout, uv installation, Python setup, and dependency installation
- Updated all three CI jobs (lint, type-check, test) to use the new composite action
- Added configurable
install-extrasparameter to support different dependency installation requirements
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/actions/setup-python-uv/action.yml |
New composite action that handles Python/uv setup with optional extras installation |
.github/workflows/ci.yml |
Simplified all three CI jobs by replacing duplicated setup steps with the composite action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Incorporated from PR #2 (copilot/sub-pr-1): - Added permissions: contents: read for security - Added enable-cache: true to setup-uv for faster builds - Added Python version matrix (3.12, 3.13) for test workflow Incorporated from PR #4 (copilot/sub-pr-1-another-one): - Added composite action .github/actions/setup-python-uv/action.yml - Updated composite action with caching and python-version input Cleaned up: - Removed Copilot conflict resolution documentation and scripts - Removed resolved-workflows directory (changes applied directly)
Addresses feedback on PR #1 to eliminate code duplication across CI jobs by extracting common setup steps into a reusable composite action.
Changes:
.github/actions/setup-python-uv/action.ymlcomposite action that handles:install-extrasparameterinstall-extras: trueto install all extrasBefore:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.