Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Addresses feedback on PR #1 to eliminate code duplication across CI jobs by extracting common setup steps into a reusable composite action.

Changes:

  • Created .github/actions/setup-python-uv/action.yml composite action that handles:
    • Repository checkout
    • uv installation and Python setup
    • Dependency installation with optional install-extras parameter
  • Updated all three CI jobs (lint, type-check, test) to use the composite action
  • Test job passes install-extras: true to install all extras

Before:

lint:
  runs-on: ubuntu-latest
  steps:
    - uses: actions/checkout@v4
    - name: Install uv
      uses: astral-sh/setup-uv@v4
      with:
        version: "latest"
    - name: Set up Python
      run: uv python install 3.12
    - name: Install dependencies
      run: uv sync --group dev
    - name: Run Ruff check
      run: uv run ruff check src/ tests/

After:

lint:
  runs-on: ubuntu-latest
  steps:
    - name: Setup Python with uv
      uses: ./.github/actions/setup-python-uv
    - name: Run Ruff check
      run: uv run ruff check src/ tests/

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Address feedback on GitHub Actions CI workflow Extract duplicated CI setup steps into composite action Nov 25, 2025
Copilot AI requested a review from jreakin November 25, 2025 19:35
Copilot AI added a commit that referenced this pull request Nov 25, 2025
jreakin added a commit that referenced this pull request Nov 25, 2025
@jreakin jreakin marked this pull request as ready for review November 25, 2025 20:01
Copilot AI review requested due to automatic review settings November 25, 2025 20:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR successfully refactors the CI workflow by extracting duplicated setup steps into a reusable composite action, reducing code duplication and improving maintainability.

Key Changes:

  • Created a composite action that consolidates repository checkout, uv installation, Python setup, and dependency installation
  • Updated all three CI jobs (lint, type-check, test) to use the new composite action
  • Added configurable install-extras parameter to support different dependency installation requirements

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/actions/setup-python-uv/action.yml New composite action that handles Python/uv setup with optional extras installation
.github/workflows/ci.yml Simplified all three CI jobs by replacing duplicated setup steps with the composite action

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

jreakin added a commit that referenced this pull request Nov 25, 2025
Incorporated from PR #2 (copilot/sub-pr-1):
- Added permissions: contents: read for security
- Added enable-cache: true to setup-uv for faster builds
- Added Python version matrix (3.12, 3.13) for test workflow

Incorporated from PR #4 (copilot/sub-pr-1-another-one):
- Added composite action .github/actions/setup-python-uv/action.yml
- Updated composite action with caching and python-version input

Cleaned up:
- Removed Copilot conflict resolution documentation and scripts
- Removed resolved-workflows directory (changes applied directly)
@jreakin jreakin closed this Nov 25, 2025
@jreakin jreakin deleted the copilot/sub-pr-1-another-one branch November 25, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants