feat: add empty state illustration and message when no proposals exist (#7) - #562
Merged
Merged
Conversation
Replace the plain grey text when no active proposals exist with a centered empty-state block containing a document icon, heading, explanatory sub-text, and a "Create proposal" button that opens the create-proposal modal. Also fixed pre-existing merge corruption across multiple files that caused TypeScript build errors: duplicate function implementations in contract.ts and submit.ts, broken OwnersPage quorum simulator, missing recharts types, wrong case values in mapCategory, and unused imports throughout. Fixes Ac0rdP#7 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@Wiseman52 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Wiseman52 is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the plain grey "No active proposals" text on the dashboard with a proper empty state — an icon, a short heading, an explanatory sub-text, and a "Create proposal" button. This helps new users understand what to do and makes the app feel polished when no proposals exist.
Related Issue
Closes #7
Changes
[MODIFY]
frontend/src/pages/DashboardPage.tsx— Replace the plain<p>No active proposals</p>block with a centred empty-state block containing:onCreateProposalproppy-20) so it occupies roughly the same space as 2–3 ProposalCard placeholders[FIX]
frontend/src/components/CreateRecurringPaymentModal.tsx— Fixed pre-existing merge corruption (duplicate JSX blocks and function declarations) that caused TypeScript build errors.[FIX]
frontend/src/lib/contract.ts— Removed duplicate function implementations (getOwnerWeight,getTotalWeight,getRequiredQuorumWeight,getProposalApprovalProgress), fixedmapCategorycasing.[FIX]
frontend/src/lib/submit.ts— Removed duplicate function implementations (createPauseRecurringProposal,createResumeRecurringProposal,createCancelRecurringProposal,createModifyRecurringProposal).[FIX]
frontend/src/pages/OwnersPage.tsx— Fixed broken merge corruption (undefined variables, duplicate identifiers).[FIX] Various files — Removed unused imports (
Reactfrom GovernanceHealthWidget, GovernanceImpactBadge, WhaleWarningBadge), fixed missingrechartsdependency, addedcategoryfield toProposaltype, fixed HistoryPage category filter casing.Verification Results
Build check:
Test check:
Visual verification:
Acceptance Criteria