feat(dashboard): add Governance Impact badge to proposal cards - #563
Merged
Merged
Conversation
Show a distinct orange gradient badge with ShieldAlert icon on proposals that alter multisig ownership or voting power (add_owner, remove_owner, change_owner_weight). Transfer and spending-limit proposals are excluded. Badge is visually distinct from the existing type badge and StatusBadge.
|
@theFirstCodeManiac is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Adejoke555 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #399
Summary
Adds a distinct Governance Impact badge to dashboard proposal cards for proposals that change multisig ownership or voting power.
Changes
Added a Governance Impact badge for:
Add-owner proposals
Remove-owner proposals
Change-owner-weight proposals
Excludes ordinary transfer and spending-limit proposals.
Styled the badge to be visually distinct from existing type and status badges.
No unrelated refactors or formatting changes.
Acceptance Criteria
Governance-changing proposals display the Governance Impact badge.
Transfer and spending-limit proposals do not display the badge.
The badge is visually distinct from existing badges.
Files Changed
frontend/src/components/ProposalCard.tsx
frontend/src/types/accord.ts