Skip to content

All cursors and custom overtype cursor#13

Closed
DrMerfy wants to merge 12 commits into
AdamMaras:masterfrom
DrMerfy:master
Closed

All cursors and custom overtype cursor#13
DrMerfy wants to merge 12 commits into
AdamMaras:masterfrom
DrMerfy:master

Conversation

@DrMerfy
Copy link
Copy Markdown

@DrMerfy DrMerfy commented Nov 24, 2018

  • Fixed issue Cursor type "block-outline" doesn't work #11 by supporting all available cursors.
  • Added a configuration setting for custom overtype support:
    "overtype.secondaryCursorStyle": "line" | "line-thin" | "block" | "block-outline" | "underline" | "underline-thin
    This setting changes the cursor style when overtype mode is selected.
  • The minimum vscode engine version is now 1.10.0 (due to new cursor addition)

@ssmooncoder
Copy link
Copy Markdown

Is this extension dead?

This branch should have been merged years ago…

@DrMerfy
Copy link
Copy Markdown
Author

DrMerfy commented Nov 8, 2020

@ssmooncoder It sure looks like it.

image

@GitMensch
Copy link
Copy Markdown

@DrMerfy would you take on the maintenance for this extension?

  • enable issues on your fork
  • pull in Fix release badge in README #18
  • adjust package.json - publisher and urls
  • adjust README
  • maybe handle some of the other issues
  • release as 0.3.0 (in this case please not only to vscode marketplace but also to Open VSX Registry

That would be awesome!

Side note: Details on the publishing can be found at https://github.com/eclipse/openvsx/wiki/Publishing-Extensions you may publish this extension with a single command, npx ovsx publish (no need to install any dependency)

@DrMerfy
Copy link
Copy Markdown
Author

DrMerfy commented Dec 16, 2020

@GitMensch Mhm okay I'll take a look in the upcoming days. Let's bring it back to life :D

@DrMerfy
Copy link
Copy Markdown
Author

DrMerfy commented Jan 2, 2021

Okay I have made all the necessary changes, you can find them also here: https://github.com/DrMerfy/vscode-overtype

(But also on the references above :) )

@GitMensch
Copy link
Copy Markdown

@DrMerfy can you close this PR? That's more than this PR was about...

@DrMerfy
Copy link
Copy Markdown
Author

DrMerfy commented Jan 6, 2021

@GitMensch True true

@DrMerfy DrMerfy closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants