Skip to content

refactor: centralize outbox event types - #318

Merged
Lakes41 merged 1 commit into
Adamantine-guild:mainfrom
dollarop:agent/outbox-event-type-enum-179
Aug 18, 2026
Merged

refactor: centralize outbox event types#318
Lakes41 merged 1 commit into
Adamantine-guild:mainfrom
dollarop:agent/outbox-event-type-enum-179

Conversation

@dollarop

Copy link
Copy Markdown
Contributor

Closes #179

Summary

  • Adds shared OUTBOX_EVENT_TYPES, OutboxEventType, and OUTBOX_EVENT_TYPE_VALUES in @guildpass/shared-types.
  • Replaces access-api outbox event-type string literals with shared constants in outbox producers/consumers.
  • Adds a focused test that verifies the shared event type list is unique and guards the main outbox modules from raw event-type literals.

Validation

  • pnpm --filter @guildpass/shared-types build
  • pnpm --filter access-api test -- outboxEventTypes.test.ts outboxService.test.ts
  • git diff --check

Notes

  • Full access-api typecheck currently hits a TypeScript RangeError: Maximum call stack size exceeded in this checkout.
  • Full lint has pre-existing errors outside this focused refactor; the changed behavior is covered by the targeted tests above.

@Lakes41
Lakes41 merged commit af7aab4 into Adamantine-guild:main Aug 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract outbox event type strings into a shared enum

2 participants