Fix test: default reachability multiplier expectation was not updated - #128
Open
msarg44 wants to merge 1 commit into
Open
Fix test: default reachability multiplier expectation was not updated#128msarg44 wants to merge 1 commit into
msarg44 wants to merge 1 commit into
Conversation
…quires_auth to externally_reachable The scoring code was updated to default to 'externally_reachable' (1.0) when no reachability tags are present. The previous default of 'requires_auth' (0.5) was deemed too penalizing, but the test expectation was not updated accordingly. 3.0 (LOW severity) × 0.7 (SANITIZATION_BYPASSABLE) × 1.0 (default) × 1.0 = 2.1
|
zocomputer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scoring code in
src/sec_af/scoring.pywas changed to default toexternally_reachable(1.0×) when no reachability tags are present (see comment in_reachability_multiplier). The previous default ofrequires_auth(0.5×) was deemed too penalizing.The test
test_compute_exploitability_score_defaults_reachability_when_missingwas not updated to reflect this change. The expected score should be2.1(3.0 × 0.7 × 1.0 × 1.0) instead of1.05(3.0 × 0.7 × 0.5 × 1.0).This fix updates the assertion to match the current scoring logic.