fix(cli): disable env proxy for local HTTP startup probes - #158
Merged
Merged
Conversation
httpx defaults to trust_env=True, which can route localhost health checks through HTTP_PROXY and cause false startup timeouts. Use trust_env=False for wait_for_http probes and assert it in tests. Made-with: Cursor
duguwanglong
approved these changes
Apr 22, 2026
duguwanglong
pushed a commit
to DearEmma/flocks
that referenced
this pull request
May 18, 2026
…s#158) httpx defaults to trust_env=True, which can route localhost health checks through HTTP_PROXY and cause false startup timeouts. Use trust_env=False for wait_for_http probes and assert it in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpx defaults to trust_env=True, which can route localhost health checks
through HTTP_PROXY and cause false startup timeouts. Use trust_env=False
for wait_for_http probes and assert it in tests.
Made-with: Cursor