Remove Docker Hub publishing; keep GHCR and clarify Docker docs - #4
Merged
Merged
Conversation
AlexanderJ-Carter
marked this pull request as ready for review
March 15, 2026 12:37
There was a problem hiding this comment.
Pull request overview
This PR removes Docker Hub login and tagging logic from the CI workflow, limiting container image publishing to GitHub Container Registry (GHCR) only.
Changes:
- Removed the optional Docker Hub login step and all Docker Hub image tag generation from the CI workflow.
- Updated the inline comment to reflect that images are now pushed to GHCR only.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: 📦 linux-command publish to NPM | ||
|
|
||
| # Docker 构建并推送(未配置 DOCKER_USER/DOCKER_PASSWORD 时跳过,不报错) | ||
| # Docker 构建并推送(仅推送到 GHCR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing on a
secretslookup and we decided to drop Docker Hub entirely while keeping GHCR publishing and GitHub Pages release flow.ghcr.io/jaywcjlove/linux-commandexclusively.