Build fixes for clang 18.1.8

[berolinux]

Fix various type differences (BOOL vs. BOOL* etc.) that cause compile failures with clang 18.1.8

https://bugs.sogo.nu/view.php?id=5997

[QHivert]

Are you sure this cause a build falied? as this method is already defined as
- (unsigned long long)getCDefaultsSize;

[berolinux]

Without this, I get

 Compiling file SOGoUserDefaults.m ...
SOGoUserDefaults.m:92:60: warning: instance method '-getCDefaultsSize' not found (return type defaults to 'id') [-Wobjc-method-access]
   92 |   [ud setObject: [NSNumber numberWithUnsignedLongLong: [up getCDefaultsSize]] forKey: @"CDefaultsSize"]; // Add c_defaults field size
      |                                                            ^~~~~~~~~~~~~~~~
./SOGoUserProfile.h:44:12: note: receiver is instance of class declared here
   44 | @interface SOGoUserProfile : NSObject
      |            ^
SOGoUserDefaults.m:92:56: error: incompatible pointer to integer conversion sending 'id' to parameter of type 'unsigned long long' [-Wint-conversion]
   92 |   [ud setObject: [NSNumber numberWithUnsignedLongLong: [up getCDefaultsSize]] forKey: @"CDefaultsSize"]; // Add c_defaults field size
      |                                                        ^~~~~~~~~~~~~~~~~~~~~
/usr/include/Foundation/NSValue.h:205:63: note: passing argument to parameter 'value' here
  205 | + (NSNumber*) numberWithUnsignedLongLong: (unsigned long long)value;
      |                                                               ^
1 warning and 1 error generated.

[QHivert]

Could you check that the two modifs in comments indeed cause a build failure?

[QHivert]

Not sure to understand the utility the void* then the NSDictionnary* casting? Can you check again if this causes a fail?

[berolinux]

Without this:

SOGoMailFolder.m:233:52: error: incompatible function pointer types sending 'NSInteger (id, id, NSDictionary *)' (aka 'long (id, id, NSDictionary *)') to parameter of type 'NSComparisonResult (*)(id, id, void *)' (aka 'enum NSComparisonResult (*)(id, id, void *)') [-Wincompatible-function-pointer-types]
  233 |   result = [fetchResults sortedArrayUsingFunction: _compareFetchResultsByUID
      |                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/Foundation/NSArray.h:145:44: note: passing argument to parameter 'comparator' here
  145 |     (NSComparisonResult (*)(id, id, void*))comparator
      |                                            ^

[QHivert]

@berolinux Hello, I've actually need to push the corrections on the (BOOL *) -> (BOOL). Could you make the adjustements on your PR? Or I can make a commit myself and credit you if you don't have the time.