Repository navigation
[codex] Fix literal TV staging asset replacement - #16
Draft
AndreKalberer wants to merge 1 commit into
Draft
AndreKalberer wants to merge 1 commit into
AndreKalberer wants to merge 1 commit into
Conversation
This was referenced Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LG TV staging interpreted JavaScript replacement tokens such as
$&inside bundled HLS as HTML replacement instructions. This corrupted the generated page with nested script tags and prevented HLS from parsing. Callback replacements now preserve dynamic asset contents literally, including JavaScript, CSS, embedded image attributes, CSP, and Samsung version capture.Adds a deterministic regression covering replacement tokens and script terminators across all six bundled scripts, plus a reusable smoke check for the actual staged page. The regression runs in
npm test.Validation:
npm testandnpm run tv:stagepassed.Physical TV hardware remains untested. Scope is four source/test files; generated packages and local profiles are excluded.