Skip to content

Conversation

@hakimio
Copy link
Collaborator

@hakimio hakimio commented Jul 1, 2025

TODO

  • Angular v20 and NX v21
  • Built-in control flow syntax
  • Standalone components, environment providers & removal of modules
  • inject() function
  • New input() & output() signal API
  • Queries as signal
  • Self-closing tags
  • Documentation & migration guide
  • Bump library versions and peer dependencies

Closes #1533

@hakimio hakimio marked this pull request as draft July 1, 2025 17:51
@splincode
Copy link
Member

@hakimio you are really powerful developer, thank you so much 🙏

@hakimio hakimio force-pushed the angular-v20 branch 2 times, most recently from 31d122b to 1aa382d Compare July 2, 2025 06:53
@hakimio hakimio force-pushed the angular-v20 branch 8 times, most recently from 82ee6b7 to 729959c Compare July 11, 2025 12:35
@hakimio hakimio force-pushed the angular-v20 branch 4 times, most recently from 60c36a9 to e45229b Compare July 16, 2025 16:11
@hakimio hakimio marked this pull request as ready for review August 29, 2025 19:23
@hakimio hakimio changed the title [WIP] feat: angular v20 and NX v21 feat: angular v20 and NX v21 Aug 29, 2025
@splincode
Copy link
Member

@hakimio Good work
image

@splincode splincode merged commit d1e911a into Angular-RU:main Sep 1, 2025
3 checks passed
@hakimio
Copy link
Collaborator Author

hakimio commented Sep 1, 2025

Thank you, Maksim 🙂

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 1, 2025

I have also refactored/fixed all the demos and updated the documentation. Can you publish a new version of them too?

@splincode
Copy link
Member

@hakimio #1535

I think the project has not been published anywhere for a long time, since no one has supported it for the last 5 years. I have added a task for deployment for now

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 1, 2025

Are you able to update the GitBook documentation?

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 1, 2025

Also, can you unpublish 18.12.0 from npm registry? It might create some confusion for the users who don't expect breaking changes in minor version.

@splincode
Copy link
Member

@hakimio done

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 1, 2025

Have you also updated the docs? I can still see the old version.

@splincode
Copy link
Member

Have you also updated the docs? I can still see the old version.

what do you mean? Where is docs? I didn't deploy any demo

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 1, 2025

The docs on gitbook.io: https://angular-ru.gitbook.io/sdk/ngxs/ngxs

@splincode
Copy link
Member

I will drop gitbook, thank you

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 4, 2025

@splincode are you planning to have some other kind of documentation after dropping gitbook docs?

@splincode
Copy link
Member

@hakimio I'm so sorry, but I don't have the time to support that project. If you're able to, please feel free to handle the maintenance

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 9, 2025

@splincode I could do a bit of work on the library but I would need full access to the github repository (merge PRs, close issues, etc) and npm publishing permissions.

@splincode
Copy link
Member

splincode commented Sep 10, 2025

@hakimio

  1. why do you need npm publishing permissions? By default, the token is already provided on CI

  2. full access to the github repository (merge PRs, close issues, etc) You have mantain role, I think is okay

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 10, 2025

If you can't trust me to give me permissions to manage PRs, issues and trigger releases of new versions, then I don't really have much incentive to work on the library.

@splincode
Copy link
Member

@hakimio Please, check about trigger releases of new versions

image

I thought this behavior gave the right to trigger releases

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 10, 2025

Is the npm publish CI job triggered when you create a new Github release? How does it decide if it's minor or major version release?

@splincode
Copy link
Member

@hakimio https://github.com/Angular-RU/angular-ru-sdk/actions/workflows/release.yml
image
image

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 10, 2025

Thanks. I have this option too.

@hakimio
Copy link
Collaborator Author

hakimio commented Sep 10, 2025

@splincode can you confirm the following Gitbook request:

image

@splincode
Copy link
Member

@hakimio done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 - Upgrade to Angular 20

2 participants