feat: allow custom headers in urlopener + pass to it from urlopen#770
Open
seemab-yamin wants to merge 2 commits intoAnswerDotAI:mainfrom
Open
feat: allow custom headers in urlopener + pass to it from urlopen#770seemab-yamin wants to merge 2 commits intoAnswerDotAI:mainfrom
seemab-yamin wants to merge 2 commits intoAnswerDotAI:mainfrom
Conversation
…ng headers param propagation
…ng headers param propagation
Contributor
Author
|
@jph00 - Please review and let me know if there is any fix or style improvement. Thanks for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Allows passing custom
headersdirectly tourlopener(headers=...)(previously it always used onlyurl_default_headers).Also propagates user
headersfromurlopen/urlread/etc →urlopener, so custom headers can override or add to defaults.Why
Before, even if you passed
headers=tourlopen, they only went to theRequestobject — the opener-level defaults were never combined or overridable per-call.Repro before fix (fails to send custom headers at opener level)