Open
Conversation
Contributor
QiuShui1012
commented
Apr 15, 2026
- 修复了 ci 发布模组时会引用错误的 AnvilLib 的问题
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI/release publishing metadata so the mod explicitly declares the correct embedded AnvilLib dependency when uploading to Modrinth/CurseForge, and updates datagen to use the standard damage-type tag provider type.
Changes:
- Switch damage type tag datagen registration to
ProviderType.DAMAGE_TYPE_TAGS. - Add explicit
dependenciesmetadata to the Modrinth/CurseForge publish steps in both CI and release workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/java/dev/dubhe/anvilcraft/data/AnvilCraftDatagen.java |
Uses the built-in DAMAGE_TYPE_TAGS provider type instead of registering a dynamic tag provider. |
.github/workflows/release.yml |
Adds explicit embedded AnvilLib dependency metadata to the publish step. |
.github/workflows/ci.yml |
Adds the same explicit embedded AnvilLib dependency metadata to the snapshot publish step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.