feat(generator): CLAUDE.md style guide + forEach→for in generated code (C35)#1136
Merged
Conversation
…ops (C35) Add generator/CLAUDE.md with conventions for: - BodyBuilder usage (appendBlock, Map.of, ifElse, forEach) - Method class pattern (writeTo, getName, no static methodName) - JSweet/TS compatibility rules - JsonUtil sync requirement between Java and TypeScript - Generated code style (underscore fields, external iteration, no unnecessary casts) - Java source style (imports over FQN, *Util naming, javadoc) Convert all forEach lambda patterns to for loops in generated code: - 13 code block templates (reader/writer/cloner) - 3 base classes (WriterUtil, AbstractTraverser, ClearMethod, MappedNodeMethods, ReaderMethod) - CreateClonersStage extra properties - Generated code: 2387 → 1 forEach remaining (Jackson Iterator API)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generator/CLAUDE.md— comprehensive style guide covering architecture, BodyBuilder conventions, method classes, JSweet compatibility, generated code style, and Java source style.forEach(lambda)patterns toforloops in generated/transpiled code (2387 → 1 remaining, which is a JacksonIterator.forEachRemainingAPI call)forEach conversion scope
Context
C35 in #1042.
Test plan