MavlinkCheckBoxBitMask: fix bitmask value formatting - #3723
Open
tatsuy wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@meee1 Could you look at this if you have time? 
Problems occur with certain parameters, such as FLTMODE_GCSBLOCK and CAN_D1_UC_SRV_BM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiexed #3696.
This is primarily a Mission Planner Set Bitmask UI issue.
Adding a small bit to a bitmask value greater than 10,000,000 makes this phenomenon easier to reproduce.
The bitmask popup previously built the selected value through a float and returned it via Value.ToString(). For larger bitmask values the displayed parameter value could be rounded before being written back to the parameter cell.
[Before]
SIM_CAN_SRV_MSK
Servo 25 -> 16777220
Servo 3 + Servo 25 -> 16777220
[After - This PR]
SIM_CAN_SRV_MSK 16777216
Servo 25 -> 16777216
Servo 3 + Servo 25 -> 16777220