Skip to content

test(functional): fix more flaky consensus tests #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oXtxNt9U merged 4 commits into from
Sep 2, 2026
Merged

test(functional): fix more flaky consensus tests #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16277eb
fix more flaky tests
oXtxNt9U Sep 1, 2026
c6b07be
empty commit
oXtxNt9U Sep 1, 2026
ae73a26
Merge branch 'develop' into fix/test/functional-consensus
sebastijankuzner Sep 1, 2026
53366eb
fix
oXtxNt9U Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/functional/consensus/source/double-sign.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,19 @@ import { assertBlockHash, assertBlockNumber, assertBlockRound } from "./asserts.
import { Validator } from "./contracts.js";
import { P2PRegistry } from "./p2p.js";
import { boot, bootMany, bootstrap, bootstrapMany, runMany, setup, stop, stopMany } from "./setup.js";
import { getNodeForValidator, getValidatorsInSlotOrder, prepareNodeValidators, snoozeForBlock } from "./utilities.js";
import {
getNodeForValidator,
getValidatorsInSlotOrder,
prepareNodeValidators,
snoozeForBlock,
snoozeUntil,
} from "./utilities.js";
import type { Contracts } from "@mainsail/contracts";

const { Propose, Prevote } = Enums.Consensus.Step;

describe<{
nodes: Contracts.Kernel.Application[],
nodes: Contracts.Kernel.Application[];
validators: Validator[];
p2p: P2PRegistry;
}>("DoubleSign", ({ beforeEach, afterEach, it, assert }) => {
Expand Down Expand Up @@ -116,6 +122,8 @@ describe<{

// No proposal went out at round 0; every validator (the proposer included) prevoted nil
// after the propose timeout, which is a later step and past the watermark.
await snoozeUntil(() => p2p.prevotes.getMessages(1, 0).length === totalNodes);

assert.equal(p2p.proposals.getMessages(1, 0).length, 0);
assert.equal(p2p.prevotes.getMessages(1, 0).length, totalNodes);

Expand Down
15 changes: 7 additions & 8 deletions tests/functional/consensus/source/prevote.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ import {
makeProposal,
prepareNodeValidators,
snoozeForBlock,
snoozeUntil,
} from "./utilities.js";
import type { Contracts } from "@mainsail/contracts";

describe<{
nodes: Contracts.Kernel.Application[],
nodes: Contracts.Kernel.Application[];
validators: Validator[];
p2p: P2PRegistry;
}>("Propose", ({ beforeEach, afterEach, it, assert, stub }) => {
Expand Down Expand Up @@ -122,13 +123,7 @@ describe<{
.getMessages(1, 0)
.map((prevote) => prevote.blockHash)
.sort(),
[
undefined,
commit.block.hash,
commit.block.hash,
commit.block.hash,
commit.block.hash,
].sort(),
[undefined, commit.block.hash, commit.block.hash, commit.block.hash, commit.block.hash].sort(),
);

// Next block
Expand Down Expand Up @@ -165,6 +160,8 @@ describe<{
await assertBlockRound(nodes, 1);
await assertBlockHash(nodes);

await snoozeUntil(() => p2p.precommits.getMessages(1, 0).length === totalNodes);

assert.equal(p2p.proposals.getMessages(1, 0).length, 1); // Assert number of proposals
assert.equal(p2p.prevotes.getMessages(1, 0).length, totalNodes); // Assert number of prevotes
assert.equal(p2p.precommits.getMessages(1, 0).length, totalNodes); // Assert number of precommits
Expand Down Expand Up @@ -261,6 +258,8 @@ describe<{
await assertBlockRound(nodes, 1);
await assertBlockHash(nodes);

await snoozeUntil(() => p2p.precommits.getMessages(1, 0).length === totalNodes);

assert.equal(p2p.proposals.getMessages(1, 0).length, 1); // Assert number of proposals
assert.equal(p2p.prevotes.getMessages(1, 0).length, totalNodes); // Assert number of prevotes
assert.equal(p2p.precommits.getMessages(1, 0).length, totalNodes); // Assert number of precommits
Expand Down
32 changes: 28 additions & 4 deletions tests/functional/consensus/source/propose.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
prepareNodeValidators,
snoozeForBlock,
snoozeForRound,
snoozeUntil,
} from "./utilities.js";
import { makeCustomProposal, makeTransactionBuilderContext } from "./custom-proposal.js";
import { EvmCalls } from "@mainsail/test-transaction-builders";
Expand Down Expand Up @@ -138,6 +139,12 @@ describe<{
await assertBlockRound(nodes, 1);
await assertBlockHash(nodes);

await snoozeUntil(
() =>
p2p.prevotes.getMessages(1, 0).length === totalNodes &&
p2p.precommits.getMessages(1, 0).length === totalNodes,
);

assert.equal(p2p.proposals.getMessages(1, 0).length, 1); // Assert number of proposals
assert.equal(p2p.prevotes.getMessages(1, 0).length, totalNodes); // Assert number of prevotes
assert.equal(p2p.precommits.getMessages(1, 0).length, totalNodes); // Assert number of precommits
Expand Down Expand Up @@ -233,6 +240,8 @@ describe<{
await assertBlockRound(nodes, 1);
await assertBlockHash(nodes);

await snoozeUntil(() => p2p.precommits.getMessages(1, 0).length === totalNodes);

assert.equal(p2p.proposals.getMessages(1, 0).length, 2); // Assert number of proposals
assert.equal(p2p.prevotes.getMessages(1, 0).length, totalNodes); // Assert number of prevotes
assert.equal(p2p.precommits.getMessages(1, 0).length, totalNodes); // Assert number of precommits
Expand Down Expand Up @@ -282,6 +291,8 @@ describe<{

await snoozeForRound(nodes, round);

await snoozeUntil(() => p2p.precommits.getMessages(1, round).length === totalNodes);

assert.equal(p2p.proposals.getMessages(1, round).length, 2); // Assert number of proposals
assert.equal(p2p.prevotes.getMessages(1, round).length, totalNodes); // Assert number of prevotes
assert.equal(p2p.precommits.getMessages(1, round).length, totalNodes); // Assert number of precommits
Expand Down Expand Up @@ -347,9 +358,11 @@ describe<{
await assertBlockRound(nodesSubset, 0);
await assertBlockHash(nodesSubset);

await snoozeUntil(() => p2p.precommits.getMessages(1, 0).length === totalNodes);

assert.equal(p2p.proposals.getMessages(1, 0).length, 2); // Assert number of proposals
assert.equal(p2p.prevotes.getMessages(1, 0).length, totalNodes); // Assert number of prevotes
assert.equal(p2p.precommits.getMessages(1, 0).length, totalNodes - 1); // Assert number of precommits
assert.equal(p2p.precommits.getMessages(1, 0).length, totalNodes); // Assert number of precommits

// Assert all nodes prevote
assert.equal(
Expand All @@ -366,10 +379,19 @@ describe<{
].sort(),
);

// // Assert all nodes precommit (null)
// The majority precommits the block; the partitioned node precommits nil.
assert.equal(
p2p.precommits.getMessages(1, 0).map((precommit) => precommit.blockHash),
Array.from({ length: totalNodes - 1 }).fill(proposal0.getPayload().block.hash),
p2p.precommits
.getMessages(1, 0)
.map((precommit) => precommit.blockHash)
.sort(),
[
proposal0.getPayload().block.hash,
proposal0.getPayload().block.hash,
proposal0.getPayload().block.hash,
proposal0.getPayload().block.hash,
undefined,
].sort(),
);

// Download blocks
Expand Down Expand Up @@ -409,6 +431,8 @@ describe<{
await assertBlockRound(nodes, 1);
await assertBlockHash(nodes);

await snoozeUntil(() => p2p.precommits.getMessages(1, 0).length === totalNodes);

assert.equal(p2p.proposals.getMessages(1, 0).length, 5); // Assert number of proposals
assert.equal(p2p.prevotes.getMessages(1, 0).length, totalNodes); // Assert number of prevotes
assert.equal(p2p.precommits.getMessages(1, 0).length, totalNodes); // Assert number of precommits
Expand Down
Loading