No-PDB changes

AsaApi/Core/Private/Ark/ArkBaseApi.h

@@ -25,7 +25,11 @@ namespace API
 
 		nlohmann::json GetConfig();
 	private:
-		bool DownloadCacheFiles(const std::filesystem::path downloadFile, const std::filesystem::path localFile);
+		bool DownloadCacheFiles(
+			const std::filesystem::path downloadFile,
+			const std::filesystem::path localFile,
+			std::filesystem::path& extractedCacheDirectory,
+			std::string& downloadedTimestamp);
 
 		// Callbacks
 		static FString LoadPlugin(FString* cmd);

AsaApi/Core/Private/Ark/HooksImpl.cpp

@@ -62,6 +62,32 @@ namespace AsaApi
 		Log::GetLog()->info("Initialized hooks\n");
 	}
 
+	std::uint32_t GenerateServerId(uint32_t originalFallbackNumber)
+	{
+		constexpr std::uint32_t MinId = 100'000'000;
+		constexpr std::uint64_t IdCount = 900'000'000ULL;
+		constexpr std::uint64_t RandomValueCount = 1ULL << 32;
+		constexpr std::uint64_t AcceptLimit = (RandomValueCount / IdCount) * IdCount;
+
+		while (true)
+		{
+			std::uint32_t randomValue = 0;
+
+			const NTSTATUS status = BCryptGenRandom(
+				nullptr,
+				reinterpret_cast<PUCHAR>(&randomValue),
+				sizeof(randomValue),
+				BCRYPT_USE_SYSTEM_PREFERRED_RNG
+			);
+
+			if (!BCRYPT_SUCCESS(status))
+				return originalFallbackNumber; // Fallback to the original number if random generation fails
+
+			if (static_cast<std::uint64_t>(randomValue) < AcceptLimit)
+				return MinId + static_cast<std::uint32_t>(static_cast<std::uint64_t>(randomValue) % IdCount);
+		}
+	}
+
 	// Hooks
 
 	void Hook_UEngine_Init(DWORD64 _this, DWORD64 InEngineLoop)
@@ -100,11 +126,11 @@ namespace AsaApi
 			if (bp.Equals("Blueprint'/Script/ShooterGame.PrimalPersistentWorldData'"))
 			{
 				if (actor->TargetingTeamField() == 0)
-					actor->TargetingTeamField() = a_shooter_game_mode->ServerIDField();
-				
+					actor->TargetingTeamField() = GenerateServerId(a_shooter_game_mode->ServerIDField()); // Use the original ServerIDField as a fallback if random generation fails
+
 				a_shooter_game_mode->MyServerIdField() = FString(std::to_string(actor->TargetingTeamField()));
 				a_shooter_game_mode->ServerIDField() = actor->TargetingTeamField();
-				Log::GetLog()->info("SERVER ID: {}", a_shooter_game_mode->ServerIDField());
+				Log::GetLog()->info("SERVER ID: {}", actor->TargetingTeamField());
 
 				break;
 			}
@@ -130,7 +156,7 @@ namespace AsaApi
 
 		if (command_executed || prevent_default)
 			return;
-		
+
 		AShooterPlayerController_ServerSendChatMessage_Impl_original(player_controller, message, mode, senderPlatform);
 	}
 
@@ -161,17 +187,17 @@ namespace AsaApi
 		Commands* command = dynamic_cast<Commands*>(API::game_api->GetCommands().get());
 		if (command)
 			command->CheckOnTimerCallbacks();
-		
+
 		API::PluginManager::DetectPluginChangesTimerCallback(); // We call this here to avoid UnknownModule crashes
 
 		AGameState_DefaultTimer_original(_this);
 	}
 
-    void Hook_AShooterGameMode_BeginPlay(AShooterGameMode* _AShooterGameMode)
-    {
-        AShooterGameMode_BeginPlay_original(_AShooterGameMode);
-        dynamic_cast<ApiUtils&>(*API::game_api->GetApiUtils()).SetStatus(ServerStatus::Ready);
-        
+	void Hook_AShooterGameMode_BeginPlay(AShooterGameMode* _AShooterGameMode)
+	{
+		AShooterGameMode_BeginPlay_original(_AShooterGameMode);
+		dynamic_cast<ApiUtils&>(*API::game_api->GetApiUtils()).SetStatus(ServerStatus::Ready);
+
 		std::uint64_t mask = 0;
 
 		LPWSTR* argv;
@@ -226,7 +252,7 @@ namespace AsaApi
 			SetProcessAffinityMask(GetCurrentProcess(), mask);
 			Log::GetLog()->info("Set process affinity mask to 0x{:016X}", mask);
 		}
-    }
+	}
 
 	bool Hook_URCONServer_Init(URCONServer* _this, FString* Password, unsigned int InPort, UShooterCheatManager* SCheatManager)
 	{

AsaApi/Core/Private/Ark/HooksImpl.h

@@ -1,6 +1,15 @@
 #pragma once
+#include <Windows.h>
+#include <bcrypt.h>
+
+#include <cstdint>
+#include <stdexcept>
+
+#pragma comment(lib, "bcrypt.lib")
 
 namespace AsaApi
 {
 	void InitHooks();
+
+	std::uint32_t GenerateServerId();
 } // namespace AsaApi

AsaApi/Core/Private/Cache.cpp

@@ -2,6 +2,7 @@
 
 #include "Cache.h"
 
+#include <array>
 #include <unordered_map>
 #include <string>
 #include <cstdint>
@@ -18,14 +19,6 @@ namespace Cache
 			return "";
 		}
 
-		const auto fileSize = std::filesystem::file_size(filename);
-		std::vector<char> buffer(fileSize);
-
-		if (!file.read(buffer.data(), fileSize)) {
-			Log::GetLog()->error("Error reading file for SHA-256 calculation: " + filename.string());
-			return "";
-		}
-
 		std::unique_ptr<EVP_MD_CTX, decltype(&EVP_MD_CTX_free)> mdctx(EVP_MD_CTX_new(), &EVP_MD_CTX_free);
 		if (mdctx == nullptr) {
 			Log::GetLog()->error("Error creating EVP_MD_CTX");
@@ -37,8 +30,21 @@ namespace Cache
 			return "";
 		}
 
-		if (EVP_DigestUpdate(mdctx.get(), buffer.data(), fileSize) != 1) {
-			Log::GetLog()->error("Error updating SHA-256 context");
+		std::array<char, 64 * 1024> buffer{};
+		while (file)
+		{
+			file.read(buffer.data(), static_cast<std::streamsize>(buffer.size()));
+			const std::streamsize bytesRead = file.gcount();
+			if (bytesRead > 0 && EVP_DigestUpdate(mdctx.get(), buffer.data(), static_cast<std::size_t>(bytesRead)) != 1)
+			{
+				Log::GetLog()->error("Error updating SHA-256 context");
+				return "";
+			}
+		}
+
+		if (!file.eof())
+		{
+			Log::GetLog()->error("Error reading file for SHA-256 calculation: " + filename.string());
 			return "";
 		}
 
@@ -60,16 +66,71 @@ namespace Cache
 		return result;
 	}
 
-	void saveToFile(const std::filesystem::path& filename, const std::string& content)
+	bool saveToFile(const std::filesystem::path& filename, const std::string& content)
 	{
-		std::ofstream file(filename, std::ios::binary | std::ios::trunc);
-		if (file.is_open()) {
-			file.write(content.data(), content.size());
-			file.close();
-			return;
+		std::filesystem::path temporaryFile = filename;
+		temporaryFile += ".tmp";
+
+		std::error_code error;
+		std::filesystem::remove(temporaryFile, error);
+
+		std::ofstream file(temporaryFile, std::ios::binary | std::ios::trunc);
+		if (!file.is_open())
+		{
+			Log::GetLog()->error("Error opening file for writing: " + temporaryFile.string());
+			return false;
 		}
 
-		Log::GetLog()->error("Error opening file for writing: " + filename.string());
+		file.write(content.data(), static_cast<std::streamsize>(content.size()));
+		file.flush();
+		file.close();
+		const bool writeSucceeded = !file.fail();
+
+		if (!writeSucceeded)
+		{
+			Log::GetLog()->error("Error writing file: " + temporaryFile.string());
+			std::filesystem::remove(temporaryFile, error);
+			return false;
+		}
+
+		HANDLE temporaryFileHandle = CreateFileW(
+			temporaryFile.c_str(),
+			GENERIC_WRITE,
+			FILE_SHARE_READ,
+			nullptr,
+			OPEN_EXISTING,
+			FILE_ATTRIBUTE_NORMAL,
+			nullptr);
+		if (temporaryFileHandle == INVALID_HANDLE_VALUE)
+		{
+			Log::GetLog()->error("Error opening temporary metadata for flushing: " + temporaryFile.string());
+			std::filesystem::remove(temporaryFile, error);
+			return false;
+		}
+
+		const bool flushSucceeded = FlushFileBuffers(temporaryFileHandle) != FALSE;
+		const DWORD flushError = flushSucceeded ? ERROR_SUCCESS : GetLastError();
+		CloseHandle(temporaryFileHandle);
+		if (!flushSucceeded)
+		{
+			Log::GetLog()->error(
+				"Error flushing temporary metadata: " + temporaryFile.string() + " (" + std::to_string(flushError) + ")");
+			std::filesystem::remove(temporaryFile, error);
+			return false;
+		}
+
+		if (!MoveFileExW(
+			temporaryFile.c_str(),
+			filename.c_str(),
+			MOVEFILE_REPLACE_EXISTING | MOVEFILE_WRITE_THROUGH))
+		{
+			Log::GetLog()->error(
+				"Error replacing file: " + filename.string() + " (" + std::to_string(GetLastError()) + ")");
+			std::filesystem::remove(temporaryFile, error);
+			return false;
+		}
+
+		return true;
 	}
 
 	std::string readFromFile(const std::filesystem::path& filename)
@@ -80,7 +141,8 @@ namespace Cache
 			file.seekg(0, std::ios::end);
 			content.resize(file.tellg());
 			file.seekg(0, std::ios::beg);
-			file.read(&content[0], content.size());
+			if (!content.empty())
+				file.read(content.data(), static_cast<std::streamsize>(content.size()));
 			return content;
 		}
 
@@ -127,4 +189,4 @@ namespace Cache
 		file.close();
 		return set;
 	}
-}
+}