refactor(agent): remove reminder override plumbing#20
refactor(agent): remove reminder override plumbing#20aryasaatvik wants to merge 22 commits intodevfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbedbdfa05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "permission", | ||
| "disable", | ||
| "tools", | ||
| "reminder", | ||
| ]) |
There was a problem hiding this comment.
Exclude deprecated reminder key from option passthrough
Removing reminder from the knownKeys set means legacy configs like agent.plan.reminder are now treated as unknown fields and copied into options, which are later merged into model/provider request options in LLM.stream (packages/opencode/src/session/llm.ts). This changes a removed config knob into a live provider parameter and can cause request failures on strict providers (or at minimum leak obsolete config into runtime model options) for users who still have reminder in existing config files.
Useful? React with 👍 / 👎.
57c77ab to
ac9b715
Compare
Summary
agent.reminderfrom config schema and runtime typesValidation