Skip to content

Comments

refactor(agent): remove reminder override plumbing#20

Open
aryasaatvik wants to merge 22 commits intodevfrom
codex/remove-reminder-patch-dependency
Open

refactor(agent): remove reminder override plumbing#20
aryasaatvik wants to merge 22 commits intodevfrom
codex/remove-reminder-patch-dependency

Conversation

@aryasaatvik
Copy link
Member

@aryasaatvik aryasaatvik commented Feb 13, 2026

Summary

  • remove agent.reminder from config schema and runtime types
  • remove plan-agent default reminder injection path from agent registry
  • stop session prompt reminder insertion from reading dynamic agent reminder overrides
  • regenerate JS SDK v2 type surface to match removed reminder fields

Validation

  • bun run typecheck
  • bun turbo build --filter opencoder

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbedbdfa05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 723 to 726
"permission",
"disable",
"tools",
"reminder",
])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude deprecated reminder key from option passthrough

Removing reminder from the knownKeys set means legacy configs like agent.plan.reminder are now treated as unknown fields and copied into options, which are later merged into model/provider request options in LLM.stream (packages/opencode/src/session/llm.ts). This changes a removed config knob into a live provider parameter and can cause request failures on strict providers (or at minimum leak obsolete config into runtime model options) for users who still have reminder in existing config files.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant