fix(app): show startup state during root redirect#1025
Conversation
|
Warning Review limit reached
More reviews will be available in 36 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Suggested priority: P2 (includes user-path files (packages/app/src/app.tsx, packages/app/src/components/app-startup-pending.tsx, packages/app/src/pages/layout.tsx)).
P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.
There was a problem hiding this comment.
Code Review
This pull request introduces a new AppStartupPending component to display a splash loading state during application startup and project autoselection, replacing generic empty loading divs. It also adds end-to-end tests to verify this startup behavior. The review feedback suggests localizing the hardcoded "Opening PawWork" string in the new component using the useLanguage hook to support internationalization.
Summary
Show a visible PawWork startup state while the root route is waiting for backend project discovery, so first-open startup does not look like a blank main pane.
Why
A renderer diagnostics export for a first-open blank-screen report showed the captured session state only after the UI had recovered. A focused delayed-backend probe reproduced the visible symptom: the shell could render while the main pane stayed empty until
/pathand/projectdiscovery finished and the app navigated into/:dir/session.The root cause is that startup autoselect blocked the layout main slot with an empty fallback. Root redirect and lazy session fallback also used empty placeholders.
Related Issue
No GitHub issue. This is a maintainer-reported first-open renderer diagnostics investigation.
Human Review Status
Pending
Review Focus
Please focus on the startup routing conditions in
Layout: direct/:dir/sessionroutes should render immediately and should not wait for startup autoselect discovery, while/still shows a non-empty startup state while backend project discovery is pending.Risk Notes
Low UI-state risk. The change does not alter backend discovery, project selection, persistence schemas, permissions, packaging, or platform-specific paths. It only replaces blank fallbacks with a visible startup state and narrows the layout blocking condition to true startup autoselect.
Conditional checklist notes:
How To Verify
Screenshots or Recordings
Visible UI was checked locally with a delayed fake backend. The captured pending state shows the PawWork splash centered in the main pane instead of an empty white surface. Local screenshot path:
/tmp/pawwork-startup-pending.png.Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.