refactor(server): effectify file json route handlers#1027
Conversation
|
Warning Review limit reached
More reviews will be available in 5 minutes and 56 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request refactors the file routes in packages/opencode/src/server/instance/file.ts to utilize the Effect library and AppRuntime.runPromise for service resolution. Additionally, a new test suite file-routes.test.ts is introduced to verify finding, listing, reading, and status retrieval of files. Feedback on the tests suggests configuring user.name and user.email inline during the git commit command to avoid potential failures in CI environments where global Git configurations might be missing.
Summary
Migrate the ordinary file JSON route handlers to the existing
AppRuntime.runPromise(Effect.gen(...))route runtime pattern.Why
This continues the #936 ordinary JSON route migration while preserving the current file search, list, read, and status contracts. Streaming, auth, workspace sync, v2, and SDK/OpenAPI source generation are not touched.
Related Issue
Refs #936
Human Review Status
Pending
Review Focus
Please check that the route handlers only delegate through the Effect services and keep existing JSON responses unchanged for file search/list/read/status.
Risk Notes
Skipped conditional checklist items:
How To Verify
Screenshots or Recordings
Not applicable; no visible UI changes.
Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.