refactor(server): effectify mcp status route#1033
Conversation
|
Warning Review limit reached
More reviews will be available in 58 minutes and 56 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request refactors the MCP status route in packages/opencode/src/server/instance/mcp.ts to resolve the MCP service and retrieve its status using the Effect framework and AppRuntime. Additionally, a new test suite has been added in packages/opencode/test/server/mcp-routes.test.ts to verify that the /mcp route correctly returns the status. There are no review comments, and I have no feedback to provide.
Summary
Migrate
GET /mcpto the existingAppRuntime.runPromise(Effect.gen(...))route runtime pattern.Why
This continues the #936 ordinary JSON route migration for the safe MCP status read path. OAuth/auth routes and connect/disconnect/add routes are intentionally left unchanged.
Related Issue
Refs #936
Human Review Status
Pending
Review Focus
Please check that this PR only moves the MCP status read through
MCP.Service.statusand does not touch OAuth or MCP connection behavior.Risk Notes
Remaining MCP routes are skipped because they involve OAuth, config mutation, or external MCP connection side effects.
Skipped conditional checklist items:
How To Verify
Screenshots or Recordings
Not applicable; no visible UI changes.
Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.