Fix per-host connection permit leak on the connect path#2288
Open
hyperxpro wants to merge 3 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
hyperxpro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
NettyConnectListener.onSuccess()removes the per-host permit from the future before the TLS handshake completes, preventingabort()from releasing it. Until the handshake succeeds, failures can still occur, leaving the permit without an owner.Modification:
Transfer permit ownership to
channel.closeFuture()as soon as it leaves the future, ensuring it is released exactly once. Also publish the channel before the handshake starts so timeout-triggered aborts can immediately close the socket.Result:
Permits are preserved across all connect-path exits, and timed-out requests now close their sockets immediately.
Fixes #2189.