Feat/api pipeline invariants di

[debbieAmoni]

ISSUE #863: Middleware Pipeline Documentation ✅

• File: docs/architecture.md

• What was added: Comprehensive middleware pipeline implementation notes with:

  • Documentation of DOCUMENTED_PIPELINE_ORDER constant
  • Module References table (8 middleware components mapped to files)
  • Testing guidance and bash commands
  • Enhanced ordering rationale with security implications

• Lines Added: ~60

ISSUE #864: Handler Invariant Checks ✅

• File: api-server/src/invariants.rs

• What was added: 4 new handler-specific invariant methods:

  • H7: verify_accept_swap() - validates Pending state and distinct parties
  • H8: verify_reveal_key() - ensures Accepted state and seller authorization
  • H9: verify_cancel_swap() - checks cancellable state and authorized cancellers
  • H10: verify_commit_ip_request() - validates owner and hash format

• Plus: 13 comprehensive test cases covering valid/invalid scenarios

• All violations: Use check_and_alert() for loud failure with metrics

• Lines Added: ~150

ISSUE #865: RPC Client Dependency Injection ✅

• File: api-server/src/dependency_injection.rs
• What was added: Comprehensive module-level documentation explaining:
  • Issue Add dependency_injection.rs wiring for the RPC client #865 RPC client wiring overview
  • 4 architectural principles (Centralized Registration, Testability, Singleton Lifetime, Type Safety)
  • Handler integration pattern with code example
  • Test setup pattern with code example
  • Enhanced RPC client methods with detailed documentation

closes #863
closes #864
closes #865

[drips-wave]

@debbieAmoni Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits