Conversation
rsnk96
marked this pull request as ready for review
March 25, 2026 22:17
- Add `separator` parameter to RedisDict (defaults to '➡️ ') - Update chain_set/get/del and multi_chain_get/multi_dict to use it - Add tests for configurable separator - Fix E302 pylama lint error (missing blank line before class) - Document `bash scripts/tests.sh` for contributors in README Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rsnk96
force-pushed
the
feat/configurable-separator
branch
from
March 26, 2026 00:00
27f0a62 to
a72224d
Compare
Attumm
self-requested a review
April 12, 2026 12:04
Attumm
requested changes
Apr 12, 2026
|
|
||
| [tool.mypy] | ||
| python_version = "3.8" | ||
| python_version = "3.9" |
Owner
There was a problem hiding this comment.
There was a reason for 3.8 and not higher. Can't remember why exactly. Hmm
Author
There was a problem hiding this comment.
Haha I'm guessing you mean the failing pylama. Well, we'll get that fixed now!
rsnk96
pushed a commit
to detecttechnologies/redis-dict
that referenced
this pull request
Apr 12, 2026
Address upstream review comments on PR Attumm#104: - Rename _DEFAULT_SEPARATOR → _DEFAULT_CHAIN_SEPARATOR to clarify purpose - Rename separator param/attr → chain_separator throughout - Revert default value from emoji to ':' for backwards compatibility - Add TODO comment to revisit default in a future major release - Revert mypy python_version back to 3.8 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rsnk96
pushed a commit
to detecttechnologies/redis-dict
that referenced
this pull request
Apr 12, 2026
Address upstream review comments on PR Attumm#104: - Rename _DEFAULT_SEPARATOR → _DEFAULT_CHAIN_SEPARATOR to clarify purpose - Rename separator param/attr → chain_separator throughout - Revert default value from emoji to ':' for backwards compatibility - Add TODO comment to revisit default in a future major release Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable chain separator to RedisDict (resolves #52). Previously, the chain separator was hardcoded to
:, which could cause key collisions when user keys contained colons. The separator is now configurable via a constructor parameter and defaults to➡️(emoji + spaces) to avoid collisions in typical use cases.Test code:
Behaviour before this PR:
Behaviour after this PR: