fix: restore PHP 8.2 support, exclude incompatible L13+8.2 cell from …#99
Merged
Conversation
…matrix The previous commit dropped PHP 8.2 from the composer constraint, which broke .github/workflows/phpstan.yml (it pins setup-php to '8.2' and therefore failed during composer install with "Root composer.json requires php ^8.3|^8.4"). Restore PHP 8.2 in composer.json and add it back to the run-tests matrix. The L13 cell on PHP 8.2 is excluded because the Laravel-13 toolchain (orchestra/testbench 11, phpunit 12, pest 4) requires PHP 8.3+; composer's OR constraints (`^11.0|^12.0|^13.0` for Laravel, `^9.0|^10.0|^11.0` for Testbench, `^11.0|^12.0` for PHPUnit, `^3.0|^4.0` for Pest) let composer pick the right minor on each PHP version automatically. Resulting CI matrix (3 PHP × 3 Laravel × 2 stability) − 2 excluded (PHP 8.2 + L13 in both stabilities) = 16 jobs. Local verification (PHP 8.4 + L13 install): - vendor/bin/pest --no-coverage → 137 passed (274 assertions), 48s - vendor/bin/phpstan analyse → 0 errors Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR Summary
|
The PHPStan workflow's path filter only watched **.php and phpstan.neon.dist, so the composer.json / matrix changes that broke PHPStan (when PHP 8.2 was the pinned analyser version and composer.json required PHP 8.3+) did not retrigger it. Adding composer.json, composer.lock and the workflow file itself to the path filter ensures PHPStan is re-validated whenever dependency resolution could be affected. workflow_dispatch is added for ad-hoc manual runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…matrix
The previous commit dropped PHP 8.2 from the composer constraint, which broke .github/workflows/phpstan.yml (it pins setup-php to '8.2' and therefore failed during composer install with "Root composer.json requires php ^8.3|^8.4").
Restore PHP 8.2 in composer.json and add it back to the run-tests matrix. The L13 cell on PHP 8.2 is excluded because the Laravel-13 toolchain (orchestra/testbench 11, phpunit 12, pest 4) requires PHP 8.3+; composer's OR constraints (
^11.0|^12.0|^13.0for Laravel,^9.0|^10.0|^11.0for Testbench,^11.0|^12.0for PHPUnit,^3.0|^4.0for Pest) let composer pick the right minor on each PHP version automatically.Resulting CI matrix (3 PHP × 3 Laravel × 2 stability) − 2 excluded (PHP 8.2 + L13 in both stabilities) = 16 jobs.
Local verification (PHP 8.4 + L13 install):