enable hotkeys controls when function is enabled #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-o-Way
requested review from
a team,
Armin2208 and
Spiritreader
as code owners
This was
linked to
issues
Oct 18, 2025
Jay-o-Way
force-pushed
the
enable-hotkeys
branch
from
d1a315a to
3333158
Compare
Contributor
|
Ah, it seems that #1119 will conflict with this PR. |
Member
Yes, please coordinate if a combination of the PRs is possible. |
Contributor
Author
|
Ah Yes. @ChenYiLins since these changes are not so big, can you copy them into your branch? |
Jay-o-Way
added
the
do not merge
Member
|
@ChenYiLins @Jay-o-Way Is this PR still relevant? |
Contributor
About ThemePickerPage still makes sense. But my suggestion is that we can create a new PR. ( •̀ ω •́ )✧ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #702, #1083
Because hotkeys can be changed while enabled.