fix(document): correctly handle modified subpaths when parent path is unset after modifying#16271
Merged
Conversation
… unset after modifying Fix #16252
vkarpov15
requested review from
AbdelrahmanHafez,
Copilot and
hasezoey
and removed request for
Copilot
hasezoey
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16252
Summary
#16252 highlighted that, when building the document delta in
$__dirty(), usetop != nullto check whether we should add the path to the delta, which breaks down if the parent path is unset. For example, ifallPaths.has(array[i])is true but the value ofarray[i]is undefined (like if unset usingdelete) Mongoose will keep the subpath in the delta.Examples