Add shared profile viewer with deep link routing by dcamozzi · Pull Request #4385 · Automattic/pocket-casts-ios

dcamozzi · 2026-05-21T00:31:24Z

Summary

Adds SharedProfileView and SharedProfileViewModel — the in-app viewer for when someone opens a shared profile link (pca.st/user/<slug>)
Wires up universal link routing in AppDelegate+SiriShortcuts.swift to intercept /user/<slug> paths and present the viewer modally via PCHostingController
Followed podcasts displayed as horizontal scrolling cards (150px) with artwork overlay subscribe buttons matching the discover screen style (circular veil-background buttons)
Subscribe buttons support both follow and unfollow with haptic feedback and scale animation
Recent episodes section with custom play button matching MainEpisodeActionView visual style
Tapping a podcast or episode presents its detail page on top of the shared profile modal (modal stays open underneath)
Presented detail pages include a close button (standard "cancel" asset) in the top-left toolbar
Each section has a "Show All" drill-down via NavigationStack
Gated behind FeatureFlag.shareProfile
View model currently uses mock data (TODO: replace with real API call once backend endpoint is ready)

Demo and Designs

View.Shared.Profile.iOS.mov

Test plan

🤖 Generated with Claude Code

Scaffold the in-app view for viewing someone else's shared profile, presented modally when opening a pca.st/user/<slug> universal link. Includes profile header, followed podcasts, and recent episodes sections with AsyncImage artwork loading and "Show All" drill-downs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

dangermattic · 2026-05-21T00:31:55Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Podcast rows now show a "+" button to subscribe (or checkmark if already subscribed). Episode rows show a play button that loads the podcast and streams the episode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Horizontal scrolling podcast cards with artwork overlay subscribe buttons - Tappable podcasts and episodes that present detail pages on top of modal - Close button on presented detail pages using standard cancel asset - Custom play button and bidirectional follow/unfollow support - Refined spacing and layout to match discover screen patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Add accessibility label to episode play button - Fix stale subscribe button state by observing podcastAdded/podcastDeleted notifications - Show podcast title in episode rows (e.g. "Only a Game · 40m") - Fix placeholder circle visibility with systemGray5/systemGray2 - Add comment explaining forced view load in addCloseButton - Remove unnecessary [self] capture in struct closure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SergioEstevao · 2026-05-21T11:03:01Z

+            navigateToPodcast(uuid: podcast.uuid)
+        } label: {
+            VStack(alignment: .leading, spacing: 0) {
+                podcastArtwork(url: podcast.artworkURL, size: cardWidth)


While this work we have an existing PodcastImage component that can will display the podcast image based on the uuid of the podcast. He has advantage of supporting placeholder images and cache across the system

SergioEstevao · 2026-05-21T11:03:39Z

+            navigateToPodcast(uuid: podcast.uuid)
+        } label: {
+            HStack(spacing: 12) {
+                podcastArtwork(url: podcast.artworkURL, size: 52)


PodcastImage can also be used here

SergioEstevao · 2026-05-21T11:06:31Z

+    }
+
+    @ViewBuilder
+    private func allEpisodesView() -> some View {


This should be split to a separate file and component to show All Episodes, ex: SharedProfileEpisodeList

Done in 95b6693

SergioEstevao · 2026-05-21T11:06:54Z

+    // MARK: - Full List Views
+
+    @ViewBuilder
+    private func allPodcastsView() -> some View {


This should be split to a separate file and component to show All Podcasts, ex: SharedProfilePodcastsList

Done in d301252

SergioEstevao · 2026-05-21T11:07:50Z

+}
+
+private extension UIViewController {
+    @objc func dismissAnimated() {


This extension method feels redudant why not just call the method above directly?

Done in 8ea6da1 — replaced with UIAction-based UIBarButtonItem to eliminate the extension.

SergioEstevao · 2026-05-21T11:08:23Z

+    }
+}
+
+private struct SharedProfileSubscribeButton: View {


This should go to a separate file. Ex: ShareProfileSubscribeButton

Done in e3e0bd0 — moved SharedProfileSubscribeButton, EpisodePlayButton, PlayTriangle, and ScaleButtonStyle to SharedProfileComponents.swift.

SergioEstevao · 2026-05-21T11:13:33Z

+            Button {
+                viewModel.playEpisode(uuid: episode.uuid, podcastUuid: episode.podcastUuid)
+            } label: {
+                EpisodePlayButton()


Should the play button change display after you press play? show a pause state? Will you be able to pause directly here?

Good question — I think for this initial version, keeping it as a simple play button makes sense since we're just launching playback from a shared profile context. We can add pause state tracking in a follow-up once we wire up the real playback state observation.

SergioEstevao

In general the functionality is working with the mock data.
I left some questions regarding code organization and about the play button states.
Tell me if you want to address it on this PR or do a follow up.

Co-Authored-By: Claude <noreply@anthropic.com>

Use UIAction-based UIBarButtonItem instead of target-action pattern, eliminating the need for a UIViewController extension. Co-Authored-By: Claude <noreply@anthropic.com>

Extracts SharedProfileSubscribeButton, EpisodePlayButton, PlayTriangle, and ScaleButtonStyle to a dedicated file. Co-Authored-By: Claude <noreply@anthropic.com>

dcamozzi · 2026-05-21T23:50:16Z

@SergioEstevao Re: using PodcastImage instead of AsyncImage for podcast card artwork and episode row artwork — Done in 669a59a

dcamozzi · 2026-05-21T23:50:38Z

Review feedback addressed

SharedProfileView.swift (@SergioEstevao): Use PodcastImage instead of AsyncImage for podcast card artwork — Done in 669a59a
SharedProfileView.swift (@SergioEstevao): Use PodcastImage instead of AsyncImage for episode row artwork — Done in 669a59a
SharedProfileView.swift (@SergioEstevao): Extract allEpisodesView to separate file SharedProfileEpisodeList — Done in 95b6693
SharedProfileView.swift (@SergioEstevao): Extract allPodcastsView to separate file SharedProfilePodcastsList — Done in d301252
SharedProfileView.swift (@SergioEstevao): Remove redundant dismissAnimated extension — Done in 8ea6da1
SharedProfileView.swift (@SergioEstevao): Move SharedProfileSubscribeButton to separate file — Done in e3e0bd0
SharedProfileView.swift (@SergioEstevao): Should play button show pause state? — Not changed; keeping as play-only for initial version, will add playback state observation in a follow-up

pocketcasts · 2026-05-22T00:48:59Z

📲 You can test the changes from this Pull Request in Pocket Casts Prototype Build by scanning the QR code below to install the corresponding build.

	App Name	Pocket Casts Prototype Build
	Build Number	`15138`
	Version	`PR #4385`
	Bundle ID	`au.com.shiftyjelly.podcasts.prototype`
	Commit	`e3e0bd0`
	Installation URL	64u5s877s8q48

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

SergioEstevao

Code looking much better!

dcamozzi requested a review from a team as a code owner May 21, 2026 00:31

dcamozzi requested review from SergioEstevao and removed request for a team May 21, 2026 00:31

Add follow and play actions to shared profile viewer

1fe24b2

Podcast rows now show a "+" button to subscribe (or checkmark if already subscribed). Episode rows show a play button that loads the podcast and streams the episode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

dcamozzi self-assigned this May 21, 2026

dcamozzi marked this pull request as draft May 21, 2026 01:40

dcamozzi and others added 2 commits May 20, 2026 19:48

dcamozzi marked this pull request as ready for review May 21, 2026 03:15

Merge remote-tracking branch 'origin/trunk' into share-profile

da96c80

dcamozzi added this to the Future milestone May 21, 2026

dcamozzi added the Feature Flag label May 21, 2026

SergioEstevao reviewed May 21, 2026

View reviewed changes

SergioEstevao requested changes May 21, 2026

View reviewed changes

dcamozzi and others added 5 commits May 21, 2026 16:38

Address review: use PodcastImage instead of AsyncImage for artwork

669a59a

Co-Authored-By: Claude <noreply@anthropic.com>

Address review: extract episode list to SharedProfileEpisodeList

95b6693

Co-Authored-By: Claude <noreply@anthropic.com>

Address review: extract podcast list to SharedProfilePodcastsList

d301252

Co-Authored-By: Claude <noreply@anthropic.com>

Address review: remove redundant dismissAnimated extension

8ea6da1

Use UIAction-based UIBarButtonItem instead of target-action pattern, eliminating the need for a UIViewController extension. Co-Authored-By: Claude <noreply@anthropic.com>

Address review: move reusable components to SharedProfileComponents

e3e0bd0

Extracts SharedProfileSubscribeButton, EpisodePlayButton, PlayTriangle, and ScaleButtonStyle to a dedicated file. Co-Authored-By: Claude <noreply@anthropic.com>

dcamozzi requested a review from SergioEstevao May 21, 2026 23:50

SergioEstevao approved these changes May 22, 2026

View reviewed changes

Conversation

dcamozzi commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Demo and Designs

Test plan

Uh oh!

dangermattic commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SergioEstevao left a comment

Choose a reason for hiding this comment

Uh oh!

dcamozzi commented May 21, 2026

Uh oh!

dcamozzi commented May 21, 2026

Review feedback addressed

Uh oh!

pocketcasts commented May 22, 2026

Uh oh!

SergioEstevao left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dcamozzi commented May 21, 2026 •

edited

Loading

dangermattic commented May 21, 2026 •

edited

Loading