[PC TV] Report tvOS platform in LiveAnalyticsStreamer#4513
Open
kean wants to merge 1 commit into
Open
Conversation
The Live analytics adapter is registered on the tvOS target but hardcoded platform: "iOS", mislabeling every tvOS event. Resolve the platform at compile time via #if os(tvOS), matching the TracksAdapter pcios/pctvos split. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the live analytics debugging adapter so tvOS events are labeled with the correct platform instead of always reporting as iOS, aligning behavior with the existing tvOS/iOS split used elsewhere in analytics.
Changes:
- Add a compile-time platform constant that resolves to
"tvOS"on tvOS builds and"iOS"otherwise. - Use the resolved platform constant when constructing
AnalyticsEventpayloads.
kean
changed the title
SergioEstevao
requested changes
Jun 12, 2026
SergioEstevao
left a comment
SergioEstevao
left a comment
Contributor
There was a problem hiding this comment.
While code looks good I'm unable to see the logs on server admin area. Could it be that tvOS needs to be added there?
Where you able to check on the server the events?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PCIOS-727.
The Live analytics adapter is already registered on the tvOS target, but
LiveAnalyticsStreamerhardcodesplatform: "iOS"— so every event sent from tvOS is mislabeled as iOS.This resolves the platform string at compile time via
#if os(tvOS), mirroring the existingpcios/pctvossplit inTracksAdapter. iOS behavior is unchanged.🤖 Generated with Claude Code