Skip to content

[PC TV] Route empty state actions in Up Next and Podcasts to Discover#4546

Merged
kean merged 1 commit into
trunkfrom
kean/tvos-empty-state-destinations
Jun 23, 2026
Merged

[PC TV] Route empty state actions in Up Next and Podcasts to Discover#4546
kean merged 1 commit into
trunkfrom
kean/tvos-empty-state-destinations

Conversation

@kean

@kean kean commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Fixes PCIOS-751.

Routes the empty-state action buttons in the Up Next and Podcasts tabs to Discover (Home) instead of triggering account creation. The requireAccount gate is dropped so the action navigates unconditionally, matching the existing Discover category empty state.

To test

  1. Sign out on Apple TV.
  2. Podcasts tab → tap "Discover podcasts" → lands on Home/Discover, no Create Account prompt.
  3. Up Next tab → tap "Add episodes" → same.

@kean kean added this to the 8.15 milestone Jun 17, 2026
@dangermattic

dangermattic commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator
2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 8.15. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean changed the base branch from trunk to kean/tvos-empty-state June 17, 2026 20:01
Base automatically changed from kean/tvos-empty-state to trunk June 18, 2026 18:00
@kean kean force-pushed the kean/tvos-empty-state-destinations branch from 91efdac to 8931bb7 Compare June 23, 2026 00:43
@kean kean marked this pull request as ready for review June 23, 2026 00:43
@kean kean requested a review from a team as a code owner June 23, 2026 00:43
@kean kean requested review from SergioEstevao and Copilot and removed request for a team June 23, 2026 00:43
@kean

kean commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

I confirmed that this is what we are going for in the ticket – marking as ready.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@SergioEstevao SergioEstevao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kean kean merged commit 89d4410 into trunk Jun 23, 2026
6 checks passed
@kean kean deleted the kean/tvos-empty-state-destinations branch June 23, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants