[PC TV] Player ellipsis menu: mark as played / archive by david-gonzalez-a8c · Pull Request #4563 · Automattic/pocket-casts-ios

david-gonzalez-a8c · 2026-06-18T18:47:59Z

Fixes PCIOS-757

Summary

Adds a third More round button to the fullscreen player's transport bar (after Playback Speed and Playback Effects) holding two state-aware episode actions: Mark Played / Mark Unplayed and Archive / Unarchive.

Mark Played and Archive confirm via alert first (matching the iOS player), because the underlying EpisodeManager calls stop playback as a side effect. Their reverses run directly.
After a destructive action's alert is confirmed, the view dismisses itself so any fullScreenCover presentation closes. The Now Playing tab is already swapped back to Home by MainTabRouter's existing playback observer, so no extra routing is needed.
All four actions are wrapped in requireAccount { … }, read from @Environment(\.requireAccount) inside NowPlayingPlayerRepresentable (where .requireAccountSupport() is applied), so logged-out users hit the create-account modal before anything runs.
The ellipsis popover shows only the action entries with no title header.

To test

Play any episode and open the fullscreen player. Verify a new ellipsis round button appears to the right of Playback Effects.
Focus it — the popover shows the entries matching the current episode's state (e.g. "Mark Played" + "Archive" for an unplayed, non-archived episode), with no title header.
Tap Mark Played → confirmation alert appears → confirm → playback stops, toast "Mark as Played" shows, the player closes (fullScreenCover dismisses, the Now Playing tab swaps back to Home).
Repeat for Archive → same behaviour with the archive confirmation alert.
Tap Mark Unplayed / Unarchive (when the inverse state is true) → action runs immediately, toast confirms, player stays open.
While logged out, tap any of the four actions → create-account modal appears instead of running the action.
User-uploaded files: confirm the archive entry is hidden (no canArchive).

Checklist

I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
I have considered adding unit tests for my changes.
] I have updated (or requested that someone edit) [the spreadsheet to reflect any new or changed analytics.

Adds a "More" menu on the fullscreen player's transport bar (third round button after Playback Speed and Playback Effects) holding the two state-aware episode actions: - Mark Played / Mark Unplayed - Archive / Unarchive Mirroring the iOS player, Mark Played and Archive both confirm via alert first ("Mark this episode as played?" / "Archive this episode?") because the underlying EpisodeManager calls stop the current playback as a side effect. Their reverses (Mark Unplayed / Unarchive) run directly. After confirming a destructive action the view dismisses itself, so fullScreenCover presentations close immediately; the tab variant is already swapped back to Home by MainTabRouter's existing playback observer. All four actions are gated by `requireAccount`, so logged-out users hit the create-account modal before anything runs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

dangermattic · 2026-06-18T18:48:20Z

	1 Warning
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

Self-review follow-up: every EpisodeManager invocation funnels through AnalyticsEpisodeHelper, which reads the last value written to `currentSource`. Without an explicit assignment from the player path, those events inherited whatever source the previous caller had set — usually `.unknown`. Set `currentSource = .player` before each markAsPlayed/markAsUnplayed/archive/unarchive call so the events match what the iOS player records. Also unify the played-side toast to L10n.markPlayedShort so it's symmetric with the unplayed-side toast (which was already short). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Copilot

Pull request overview

Adds a new “More” (ellipsis) transport-bar menu to the tvOS fullscreen player that exposes episode actions (Mark Played/Unplayed and Archive/Unarchive), including confirmation alerts for the destructive variants and dismissal behavior after those actions.

Changes:

Adds a new localized title for the tvOS player ellipsis menu (“More”).
Extends NowPlayingViewModel with played/archived state accessors and action methods (mark played/unplayed, archive/unarchive).
Updates NowPlayingView / AVPlayerViewController transport bar to include a new custom UIMenu for episode actions, plus confirmation alerts for Mark Played and Archive.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
podcasts/en.lproj/Localizable.strings	Adds `tv_player_more` string used as the ellipsis menu title.
Pocket Casts TV App/UI/Player/NowPlayingViewModel.swift	Adds state + action helpers used by the new ellipsis menu entries.
Pocket Casts TV App/UI/Player/NowPlayingView.swift	Adds the “More” transport-bar menu, account-gated action handling, and confirmation alerts/dismissal behavior.

kean · 2026-06-18T21:33:32Z

+    // `NowPlayingView` is hosted inside a `fullScreenCover`, which doesn't
+    // inherit the requireAccount environment from its presenter — read it
+    // back here so the ellipsis-menu actions can gate themselves.
+    @Environment(\.requireAccount) private var requireAccount
+    // Mark Played and Archive both stop playback, which leaves the player


That is the case. If you don't have an account and select on of the new options from the player, nothing happens.

Done in 83d8e07

david-gonzalez-a8c · 2026-06-19T13:44:20Z

 private struct NowPlayingPlayerRepresentable: UIViewControllerRepresentable {
    @Bindable var model: NowPlayingViewModel
    @Binding var isShowingDescription: Bool
+    @Binding var isShowingMarkAsPlayedConfirmation: Bool
+    @Binding var isShowingArchiveConfirmation: Bool
+    let requireAccount: RequireAccountAction
    @State private var isTransportBarVisible = true


Done in 83d8e07

kean

I tested multiple scenarios including "Now Playing" and the "Player", which are different environments, and both worked well. There is a one issue with logged-out experience that Copilot also flagged.

kean · 2026-06-18T21:33:32Z

+    // `NowPlayingView` is hosted inside a `fullScreenCover`, which doesn't
+    // inherit the requireAccount environment from its presenter — read it
+    // back here so the ellipsis-menu actions can gate themselves.
+    @Environment(\.requireAccount) private var requireAccount
+    // Mark Played and Archive both stop playback, which leaves the player


That is the case. If you don't have an account and select on of the new options from the player, nothing happens.

kean · 2026-06-18T21:33:59Z

+    // empty. Dismiss closes the fullScreenCover variants; the Now Playing
+    // *tab* is separately swapped back to Home by `MainTabRouter`'s
+    // existing playback observer.
+    @Environment(\.dismiss) private var dismiss


I tested the scenario where you are on "Now Playing", use "Archive" and the queue has more items or the queue is empty. It was a bit abrupt in terms of animations, but it worked ok. For the "no items" scenarios, it removed the "Now Playing" tab and returned me to "Home".

Screen.Recording.2026-06-18.at.5.39.33.PM.mov

kean · 2026-06-18T21:44:53Z

 "tv_player_playback_effects" = "Playback effects";

+/* tv player ellipsis menu title; sits above episode actions like Mark Played and Archive */
+"tv_player_more" = "More";


(nit) the title seems a bit redundant

Done in 0f3aa00 — dropped the title so the popover shows just the actions.

@Environment

Move @Environment(\.requireAccount) into NowPlayingPlayerRepresentable, where .requireAccountSupport() is actually applied. Reading it in the parent NowPlayingView resolved to the default no-op (actions run immediately) since the modifier installs the gated implementation on its content's environment, not its parent's. Co-Authored-By: Claude <noreply@anthropic.com>

The popover header showed "More" above Mark Played / Archive, repeating what the ellipsis icon already implies. Drop the title (and the unused tv_player_more string) so the popover only shows the actions. Co-Authored-By: Claude <noreply@anthropic.com>

david-gonzalez-a8c · 2026-06-19T13:45:11Z

@kean Re: your review — the logged-out gating issue Copilot flagged is fixed in 83d8e07 (moved @Environment(\.requireAccount) into the representable where .requireAccountSupport() is actually applied).

david-gonzalez-a8c · 2026-06-19T13:45:25Z

Review feedback addressed

NowPlayingView.swift:14 (@copilot): requireAccount env was read in NowPlayingView, where .requireAccountSupport() hadn't been applied yet, so the gated implementation was never seen — moved the @Environment(\.requireAccount) read into NowPlayingPlayerRepresentable. Done in 83d8e07.
NowPlayingView.swift:71 (@copilot): Same root cause as above — fixed by the same change. Done in 83d8e07.
Localizable.strings:6191 (@kean): "More" header above the ellipsis menu was redundant — dropped the title (and removed the unused tv_player_more string). Done in 0f3aa00.
Review (@kean): Logged-out gating issue you flagged is covered by the requireAccount fix above. Done in 83d8e07.

Not changed:

NowPlayingView.swift:18 (@kean): Animation observation during Archive from Now Playing — noted, but no actionable change requested.
NowPlayingView.swift:256 (@kean): "played episode in player" question — already answered inline (played episodes can still be played).

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+                requireAccount {
+                    AnalyticsEpisodeHelper.shared.currentSource = .player
+                    model.markAsUnplayed()
+                    ToastManager.shared.show(L10n.markUnplayedShort)
+                }


+                    requireAccount {
+                        AnalyticsEpisodeHelper.shared.currentSource = .player
+                        model.unarchive()
+                        ToastManager.shared.show(L10n.unarchive)
+                    }


david-gonzalez-a8c marked this pull request as ready for review June 18, 2026 18:52

david-gonzalez-a8c requested a review from a team as a code owner June 18, 2026 18:52

david-gonzalez-a8c requested review from Copilot and kean and removed request for a team June 18, 2026 18:52

Copilot started reviewing on behalf of david-gonzalez-a8c June 18, 2026 18:53 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

kean added the [Project] tvOS label Jun 18, 2026

kean added this to the 8.15 milestone Jun 18, 2026

kean requested changes Jun 18, 2026

View reviewed changes

david-gonzalez-a8c and others added 2 commits June 19, 2026 15:41

david-gonzalez-a8c requested a review from kean June 19, 2026 13:45

Copilot started work on behalf of david-gonzalez-a8c June 19, 2026 13:45 View session

david-gonzalez-a8c requested a review from Copilot June 19, 2026 13:47

Copilot finished work on behalf of david-gonzalez-a8c June 19, 2026 13:47

Copilot started reviewing on behalf of david-gonzalez-a8c June 19, 2026 13:47 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Conversation

david-gonzalez-a8c commented Jun 18, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

To test

Checklist

Uh oh!

dangermattic commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

kean Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

david-gonzalez-a8c Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

david-gonzalez-a8c Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

kean left a comment

Choose a reason for hiding this comment

Uh oh!

kean Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

kean Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kean Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

david-gonzalez-a8c Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

david-gonzalez-a8c commented Jun 19, 2026

Uh oh!

david-gonzalez-a8c commented Jun 19, 2026

Review feedback addressed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

david-gonzalez-a8c commented Jun 18, 2026 •

edited by Copilot AI

Loading

dangermattic commented Jun 18, 2026 •

edited

Loading