Skip to content

[WIP] [PC TV] Derive playlist pill colour from front cover artwork#4575

Closed
Copilot wants to merge 1 commit into
playlist-colorsfrom
copilot/pc-tv-derive-playlist-pill-colour
Closed

[WIP] [PC TV] Derive playlist pill colour from front cover artwork#4575
Copilot wants to merge 1 commit into
playlist-colorsfrom
copilot/pc-tv-derive-playlist-pill-colour

Conversation

Copilot AI commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #4561. I've created this new PR, which merges into #4561, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #4561
Triggering comment (#4561 (comment)):

Review feedback addressed

  • PlaylistDetailsViewModel.swift:188 (@copilot): hoist fallback palette to a static let — Done in 7f2df70
  • PlaylistDetailsViewModel.swift:140 (@kean): cache playlistColor so it isn't recomputed on every body — Done in 0b6c840
  • General (@kean): reduce the number of code comments — Done in 8c3ad3d
  • Testing notes (@kean): darker tints / two playlists landing on the same fallback colour — acknowledged; deferred to a follow-up PR so this one stays scoped to the review fixes

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dangermattic

Copy link
Copy Markdown
Collaborator
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Copilot AI requested a review from david-gonzalez-a8c June 19, 2026 13:42
@david-gonzalez-a8c david-gonzalez-a8c marked this pull request as ready for review June 19, 2026 13:43
Copilot AI review requested due to automatic review settings June 19, 2026 13:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants