Skip to content

Conversation

@sejas
Copy link
Member

@sejas sejas commented Nov 26, 2025

Related issues

Proposed Changes

  • Add search input and controlled scroll to create and pull remote site flow

Testing Instructions

  • Enable the beta feature "Site creation from existing remote site"
  • Click on Add site
  • Click on Import existing remote site
  • Observe that a search bar exists and works as expected
  • Observe the scroll of sites works as expected
search-scroll-pull-remote-site-creation-flow.mp4

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

📊 Performance Test Results

Comparing a5f0d89 vs trunk

site-editor

Metric trunk a5f0d89 Diff Change
load 13857.00 ms 11388.00 ms -2469.00 ms 🟢 -17.8%

site-startup

Metric trunk a5f0d89 Diff Change
siteCreation 21156.00 ms 18106.00 ms -3050.00 ms 🟢 -14.4%
siteStartup 7986.00 ms 7984.00 ms -2.00 ms 🟢 -0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@sejas sejas requested a review from a team November 27, 2025 10:31
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas for adding this improvement! I have tested it, and it works as expected, the search and scroll works fine. LGTM! :shipit:

List of sites Search
Image Image

@sejas sejas merged commit 9c815c0 into trunk Nov 28, 2025
10 checks passed
@sejas sejas deleted the add/stu-1013-search-bar-to-pull-remote-site-create-flow branch November 28, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants