Skip to content

Agentic UI: Fix border for Theme selector - #4335

Merged
nightnei merged 1 commit into
trunkfrom
agenticFixBorderForTheme
Jul 28, 2026
Merged

Agentic UI: Fix border for Theme selector#4335
nightnei merged 1 commit into
trunkfrom
agenticFixBorderForTheme

Conversation

@nightnei

@nightnei nightnei commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

AI assisted. I was thinking about something simpler, but ultimately decided to go with AI's proposition.

Proposed Changes

  1. Run Agentic UI
  2. Open Settings
  3. Assert that there is no double border when the first or last item is selected (I added a red border via dev tools to easy testing):
BEFORE AFTER
Screenshot 2026-07-24 at 16 23 46 Screenshot 2026-07-24 at 16 23 22

@nightnei
nightnei requested review from bcotrim and sejas July 24, 2026 15:28
@nightnei nightnei self-assigned this Jul 24, 2026
@wpmobilebot

wpmobilebot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 3e61aaf vs trunk

app-size

Metric trunk 3e61aaf Diff Change
App Size (Mac) 1377.87 MB 1377.87 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 3e61aaf Diff Change
load 1083 ms 1081 ms 2 ms ⚪ 0.0%

site-startup

Metric trunk 3e61aaf Diff Change
siteCreation 6976 ms 6987 ms +11 ms ⚪ 0.0%
siteStartup 2347 ms 2364 ms +17 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

shaunandrews pushed a commit that referenced this pull request Jul 24, 2026
@nightnei @claude @shaunandrews
Agentic UI settings: fix theme-selector border and align site-directo…
8721cc4 
…ry input

Backports PR #4335 (single continuous edge on the appearance segmented control) and PR #4337 (site-directory picker matches the standard SelectControl trigger; drop its file icon) onto the design-preview branch.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bcotrim
bcotrim approved these changes Jul 27, 2026
View reviewed changes

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nightnei
nightnei merged commit 3357ee7 into trunk Jul 28, 2026
15 checks passed
@nightnei
nightnei deleted the agenticFixBorderForTheme branch July 28, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcotrim bcotrim bcotrim approved these changes
@sejas sejas Awaiting requested review from sejas

Assignees

@nightnei nightnei

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nightnei @wpmobilebot @bcotrim