Agentic UI: fix resizer for chat input - #4338
Merged
Merged
Conversation
Contributor
|
Yup! Makes a lot of sense for keyboard resizing. Can we make the line rounded on the ends, similar to how the handle looks for the sidebar. |
Collaborator
📊 Performance Test ResultsComparing 42fbe1c vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Author
Addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI assisted
Proposed Changes
Shaun asked to avoid highlighting the chat input resizer on hover, so this PR addresses it.
@shaunandrews I was thinking about accessing the resizer via
tabbutton, sicne we need to highlight it in this case, so I left the highlight viatab. Is it ok or ytou would you prefer another approach?Testing Instructions
Tabbutton a few times to have the chat input resizer focused