Skip to content

Simplify and align the analytics toggle in legacy settings - #4358

Merged
wojtekn merged 1 commit into
trunkfrom
fix-analytics-toggle-alignment
Jul 28, 2026
Merged

Simplify and align the analytics toggle in legacy settings#4358
wojtekn merged 1 commit into
trunkfrom
fix-analytics-toggle-alignment

Conversation

@wojtekn

@wojtekn wojtekn commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Claude Code applied a designer's feedback: removed the redundant description line and computed the left padding needed to align the checkbox with the CLI toggle (based on the rendered @wordpress/components control dimensions).

Proposed Changes

The analytics opt-out checkbox in the legacy (apps/studio) Settings screen previously rendered a second line of descriptive text and sat with its own indentation.

Per design feedback:

  • Removed the secondary description line, so the setting is now a single, cleaner label — consistent with how this screen is being wound down.
  • Added left padding so the checkbox's right edge lines up with the right edge of the "Studio CLI for terminal" switch above it, and both settings' labels line up on the left. This makes the two adjacent controls read as a coherent group.

Testing Instructions

  1. Open Settings (General tab) in Studio.
  2. Confirm the "Help improve Studio by sharing anonymous usage statistics" checkbox no longer shows a second line of description text.
  3. Confirm the checkbox's right edge aligns with the right edge of the "Studio CLI for terminal" switch, and both labels start at the same left position.
  4. Verify in both light and dark color schemes.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn
wojtekn requested review from a team and shaunandrews July 27, 2026 14:30
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 8c72196 vs trunk

app-size

Metric trunk 8c72196 Diff Change
App Size (Mac) 1375.46 MB 1375.46 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk 8c72196 Diff Change
load 1067 ms 1030 ms 37 ms ⚪ 0.0%

site-startup

Metric trunk 8c72196 Diff Change
siteCreation 6990 ms 7019 ms +29 ms ⚪ 0.0%
siteStartup 2356 ms 2376 ms +20 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@shaunandrews

Copy link
Copy Markdown
Contributor
image

The alignment looks better. Thanks!

@wojtekn
wojtekn merged commit 83fcdac into trunk Jul 28, 2026
15 checks passed
@wojtekn
wojtekn deleted the fix-analytics-toggle-alignment branch July 28, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants