Update report post to use new 'message' field and fetch form from server#1235
Merged
Update report post to use new 'message' field and fetch form from server#1235
Conversation
The forums changed the report post form field from 'comments' to 'message' and increased the character limit from 960 to 1000. The report form is now fetched from the server before displaying, which allows the app to show the site's own instruction text, NWS label, and character limit. If the post has already been reported, the server's error message is displayed with a tappable dismiss link instead of the form. Also fixes several pre-existing UI issues: NWS label visibility in dark mode, content clipping under the sheet handle, NWS toggle placed inline with its label, and text view/switch theming using sheet-appropriate theme colors. Added a new theme key for sheetTextAreaBorderColor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forums changed the report post form field from 'comments' to 'message' and increased the character limit from 960 to 1000.
The report form is now fetched from the server before displaying, which allows the app to show the site's own instruction text, NWS label, and character limit.
If the post has already been reported, the server's error message is displayed with a tappable dismiss link instead of the form.
Also fixes several pre-existing UI issues: NWS label visibility in dark mode, content clipping under the sheet handle, NWS toggle placed inline with its label, and text view/switch theming using sheet-appropriate theme colors.
Added a new theme key for sheetTextAreaBorderColor.