fix(e2e): skip NetworkIsolated tests in GPU E2E pipeline#8267
Closed
ganeshkumarashok wants to merge 1 commit intomainfrom
Closed
fix(e2e): skip NetworkIsolated tests in GPU E2E pipeline#8267ganeshkumarashok wants to merge 1 commit intomainfrom
ganeshkumarashok wants to merge 1 commit intomainfrom
Conversation
The GPU E2E pipeline runs all tests with `gpu=true` but doesn't have network-isolated cluster infrastructure. Tests tagged with both `GPU=true` and `NetworkIsolated=true` fail because the pipeline can't provision network-isolated clusters (private ACR, NSG rules, etc.). Add `NetworkIsolated=true` to TAGS_TO_SKIP so these tests are skipped in the GPU pipeline. They can still be run locally or in a dedicated network-isolated pipeline.
ganeshkumarashok
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GPU E2E Azure DevOps pipeline to skip network-isolated scenarios that the GPU pipeline infrastructure can’t currently provision (e.g., missing private ACR / restricted egress setup), preventing predictable CI failures while still running standard GPU-tagged tests.
Changes:
- Extend
TAGS_TO_SKIPin the GPU E2E pipeline to includeNetworkIsolated=true. - Keep the GPU pipeline scope as
TAGS_TO_RUN: gpu=truewhile excluding Windows and network-isolated scenarios.
Contributor
Author
|
Closing: wrong approach. The test should run in the GPU pipeline, not be skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e-gpu.yaml) runs all tests taggedgpu=truebut doesn't have network-isolated cluster infrastructure (private ACR, NSG outbound rules, etc.)GPU=trueandNetworkIsolated=true(e.g.,Test_Ubuntu2404_FullyManagedGPU_NetworkIsolatedfrom test: add E2E test for fully managed GPU + network isolation #8253) fail because the pipeline can't provision network-isolated clustersNetworkIsolated=truetoTAGS_TO_SKIPin the GPU pipeline so these tests are skippede2e.yaml) already skipsgpu=truetests, so this doesn't change behavior thereTest plan
NetworkIsolatedtestsNetworkIsolated: true)