feat(vscode): Enable MI option in connector setup#9390
Open
andrew-eldridge wants to merge 1 commit into
Open
Conversation
This reverts commit 78d8ddb.
Contributor
🤖 AI PR Validation ReportPR passes. The advised risk level matches the submitter's estimate ( Last updated: Mon, 13 Jul 2026 15:29:50 GMT |
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | |
| Commit Type | ✅ | |
| Risk Level | ✅ | |
| What & Why | ✅ | |
| Impact of Change | ✅ | |
| Test Plan | ✅ | |
| Contributors | ✅ | |
| Screenshots/Videos | ✅ |
This PR passes review for title/body compliance. The advised risk level remains low and matches the submitter’s assessment.
Last updated: Mon, 13 Jul 2026 15:29:42 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the Managed Identity (MI) authentication option in the VS Code Azure connector setup wizard by restoring the authentication-method prompt step behavior.
Changes:
- Restore
AuthenticationMethodSelectionStep.shouldPrompt()so the wizard prompts for an auth method when Azure connectors are enabled and no method has been selected. - Remove the prior “always default to rawKeys” behavior and its corresponding test expectations.
- Update unit tests to align with the re-enabled prompt flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/vs-code-designer/src/app/commands/workflows/authenticationMethodStep.ts | Restores prompt gating logic so users can select MI vs connection keys when connectors are enabled. |
| apps/vs-code-designer/src/app/commands/workflows/test/authenticationMethodStep.test.ts | Adjusts unit tests for the updated shouldPrompt behavior. |
Contributor
📊 Coverage Check🎉 All changed files have adequate test coverage! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit #9364
Commit Type
Risk Level
What & Why
Re-enable MI option for connectors auth since latest bundle includes fix for previously observed issues
Impact of Change
Test Plan
Contributors
@andrew-eldridge