fix: patch path-to-regexp ReDoS (GHSA-37ch-88jc-xwx2) and migrate pnpm overrides to pnpm-workspace.yaml#2008
Closed
mikeharder with Copilot wants to merge 2 commits into
Closed
fix: patch path-to-regexp ReDoS (GHSA-37ch-88jc-xwx2) and migrate pnpm overrides to pnpm-workspace.yaml#2008mikeharder with Copilot wants to merge 2 commits into
mikeharder with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix vulnerability in path-to-regexp due to regex denial of service
fix: patch path-to-regexp ReDoS (GHSA-37ch-88jc-xwx2) and migrate pnpm overrides to pnpm-workspace.yaml
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path-to-regexp@0.1.12(transitive viaexpress@4.21.2) is vulnerable to ReDoS when routes contain three or more parameters in a single segment (e.g./:a-:b-:c). Patched in0.1.13.Changes
pnpm-workspace.yaml— Addedoverridessection withpath-to-regexp@0.1: ">=0.1.13"and migrated all existing overrides frompackage.json(pnpm 10.10.0 silently ignores thepnpmfield inpackage.json; overrides must now live inpnpm-workspace.yaml)package.json— Removed the now-ignoredpnpm.overridesfieldpnpm-lock.yaml— Regenerated;path-to-regexp@0.1.12no longer presentReachability
Not reachable (high confidence). Express is only used in test mock servers in
packages/autorest.gotest; no routes use multi-parameter single-segment patterns. Update primarily satisfies vulnerability scanners.Original prompt
This section details the Dependabot vulnerability alert you should resolve
<alert_title>path-to-regexp vulnerable to Regular Expression Denial of Service via multiple route parameters</alert_title>
<alert_description>### Impact
A bad regular expression is generated any time you have three or more parameters within a single segment, separated by something that is not a period (
.). For example,/:a-:b-:cor/:a-:b-:c-:d. The backtrack protection added inpath-to-regexp@0.1.12only prevents ambiguity for two parameters. With three or more, the generated lookahead does not block single separator characters, so capture groups overlap and cause catastrophic backtracking.Patches
Upgrade to path-to-regexp@0.1.13
Custom regex patterns in route definitions (e.g.,
/:a-:b([^-/]+)-:c([^-/]+)) are not affected because they override the default capture group.Workarounds
All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change
/:a-:b-:cto/:a-:b([^-/]+)-:c([^-/]+).If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length.
References
high
https://github.com/pillarjs/path-to-regexp/security/advisories/GHSA-37ch-88jc-xwx2 https://nvd.nist.gov/vuln/detail/CVE-2026-4867 https://blakeembrey.com/posts/2024-09-web-redos https://cna.openjsf.org/security-advisories.html https://github.com/advisories/GHSA-9wv6-86v2-598j https://github.com/pillarjs/path-to-regexp/releases/tag/v.0.1.13 https://github.com/advisories/GHSA-37ch-88jc-xwx2GHSA-37ch-88jc-xwx2, CVE-2026-4867
path-to-regexp
npm
<vulnerable_versions>0.1.12</vulnerable_versions>
<patched_version>0.1.13</patched_version>
<manifest_path>pnpm-lock.yaml</manifest_path>
<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails ...