Skip to content

fix: patch path-to-regexp ReDoS (GHSA-37ch-88jc-xwx2) and migrate pnpm overrides to pnpm-workspace.yaml#2008

Closed
mikeharder with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-path-to-regexp-vulnerability
Closed

fix: patch path-to-regexp ReDoS (GHSA-37ch-88jc-xwx2) and migrate pnpm overrides to pnpm-workspace.yaml#2008
mikeharder with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-path-to-regexp-vulnerability

Conversation

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

path-to-regexp@0.1.12 (transitive via express@4.21.2) is vulnerable to ReDoS when routes contain three or more parameters in a single segment (e.g. /:a-:b-:c). Patched in 0.1.13.

Changes

  • pnpm-workspace.yaml — Added overrides section with path-to-regexp@0.1: ">=0.1.13" and migrated all existing overrides from package.json (pnpm 10.10.0 silently ignores the pnpm field in package.json; overrides must now live in pnpm-workspace.yaml)
  • package.json — Removed the now-ignored pnpm.overrides field
  • pnpm-lock.yaml — Regenerated; path-to-regexp@0.1.12 no longer present

Reachability

Not reachable (high confidence). Express is only used in test mock servers in packages/autorest.gotest; no routes use multi-parameter single-segment patterns. Update primarily satisfies vulnerability scanners.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>path-to-regexp vulnerable to Regular Expression Denial of Service via multiple route parameters</alert_title>
<alert_description>### Impact

A bad regular expression is generated any time you have three or more parameters within a single segment, separated by something that is not a period (.). For example, /:a-:b-:c or /:a-:b-:c-:d. The backtrack protection added in path-to-regexp@0.1.12 only prevents ambiguity for two parameters. With three or more, the generated lookahead does not block single separator characters, so capture groups overlap and cause catastrophic backtracking.

Patches

Upgrade to path-to-regexp@0.1.13

Custom regex patterns in route definitions (e.g., /:a-:b([^-/]+)-:c([^-/]+)) are not affected because they override the default capture group.

Workarounds

All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change /:a-:b-:c to /:a-:b([^-/]+)-:c([^-/]+).

If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length.

References

high
GHSA-37ch-88jc-xwx2, CVE-2026-4867
path-to-regexp
npm
<vulnerable_versions>0.1.12</vulnerable_versions>
<patched_version>0.1.13</patched_version>
<manifest_path>pnpm-lock.yaml</manifest_path>

https://github.com/pillarjs/path-to-regexp/security/advisories/GHSA-37ch-88jc-xwx2 https://nvd.nist.gov/vuln/detail/CVE-2026-4867 https://blakeembrey.com/posts/2024-09-web-redos https://cna.openjsf.org/security-advisories.html https://github.com/advisories/GHSA-9wv6-86v2-598j https://github.com/pillarjs/path-to-regexp/releases/tag/v.0.1.13 https://github.com/advisories/GHSA-37ch-88jc-xwx2

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails ...

Copilot AI changed the title [WIP] Fix vulnerability in path-to-regexp due to regex denial of service fix: patch path-to-regexp ReDoS (GHSA-37ch-88jc-xwx2) and migrate pnpm overrides to pnpm-workspace.yaml Jun 24, 2026
Copilot AI requested a review from mikeharder June 24, 2026 06:37
@mikeharder mikeharder closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants