Skip to content

Pin markdown-it to 14.2.0 to remediate GHSA-6v5v-wf23-fmfq (CVE-2026-48988)#2016

Closed
mikeharder with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-smartquotes-vulnerability
Closed

Pin markdown-it to 14.2.0 to remediate GHSA-6v5v-wf23-fmfq (CVE-2026-48988)#2016
mikeharder with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-smartquotes-vulnerability

Conversation

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

markdown-it@14.1.1 is vulnerable to quadratic-time DoS in the smartquotes rule when typographer: true is used. This repo resolved that vulnerable version transitively, so Dependabot could not auto-remediate without an explicit workspace-level constraint.

  • Dependency remediation

    • Added a workspace override in pnpm-workspace.yaml to force markdown-it to 14.2.0 (lowest patched version).
    • Regenerated pnpm-lock.yaml via pnpm so all resolutions now point to markdown-it@14.2.0.
  • Resolution path addressed

    • The vulnerable package was pulled transitively through @typespec/tspd -> typedoc -> markdown-it.
    • The override removes the vulnerable lockfile resolution and unblocks security update automation.
  • Reachability Assessment

    • Result: Not directly reachable in product runtime code.
    • Details: Repository search found no direct markdown-it usage or typographer: true configuration in source paths; usage is transitive in tooling/docs generation dependency graph.
    • Confidence: High (explicit dependency chain inspection + codebase search).
# pnpm-workspace.yaml
overrides:
  markdown-it: 14.2.0
Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>markdown-it: Quadratic complexity DoS in smartquotes rule via replaceAt string operations</alert_title>
<alert_description>### Summary

A quadratic time complexity vulnerability exists in markdown-it's smartquotes rule (enabled via the typographer: true option). An attacker can craft a markdown input consisting of consecutive quotation marks that causes the parser to consume excessive CPU time, leading to denial of service.

Details

The vulnerability is in the replaceAt() helper function used by the smartquotes rule in lib/rules_core/smartquotes.mjs:

function replaceAt (str, index, ch) {
  return str.slice(0, index) + ch + str.slice(index + 1)
}

When markdown-it processes a text token containing many quotation marks (either " or ') with typographer: true, the smartquotes rule iterates through each quote character and calls replaceAt() to substitute it with a typographic (curly) quote. Each call to replaceAt() creates three new string slices and concatenates them, which is an O(n) operation where n is the length of the string.

Since this is called once per quote character in the token, and there are n quote characters, the total time complexity becomes O(n^2).

The root cause is that the smartquotes rule modifies token.content in place using string slicing rather than building the result incrementally. The process_inlines() function (line 14) processes each quote in the text token, and for matching quote pairs, calls replaceAt() on both the opening and closing token's content (lines 151-152). When the entire input is a single text token of quote characters, this results in quadratic behavior.

PoC

const md = require('markdown-it');
const instance = md({ typographer: true });

// 160,000 consecutive double-quote characters
const payload = '"'.repeat(160000);

console.time('render');
instance.render(payload);
console.timeEnd('render');
// Output: render: ~21000ms (21 seconds)

// Compare with typographer disabled:
const safe = md({ typographer: false });
console.time('render-safe');
safe.render(payload);
console.timeEnd('render-safe');
// Output: render-safe: ~8ms

Measured timing on a modern system:

  • 10,000 quotes: ~19ms
  • 20,000 quotes: ~51ms
  • 40,000 quotes: ~212ms
  • 80,000 quotes: ~5,430ms
  • 160,000 quotes: ~21,198ms

The scaling is clearly superlinear (quadratic), with the 80K->160K step showing a ~3.9x increase for a 2x input increase, consistent with O(n^2).

Impact

Applications that render user-supplied markdown with typographer: true are vulnerable to denial of service. An attacker can submit a relatively small payload (160KB of quote characters) that causes the server to spend over 21 seconds processing a single request. Repeated submissions can exhaust server CPU resources and prevent legitimate users from being served.

The impact is mitigated by the fact that the typographer option defaults to false and must be explicitly enabled. However, the typographer feature is commonly enabled in production applications that want smart typography, and the markdown-it documentation prominently suggests enabling it.

A suggested fix would be to replace the replaceAt() approach with an array-based or StringBuilder-style approach that collects all replacements and applies them in a single pass, reducing the time complexity to O(n).</alert_description>

moderate
GHSA-6v5v-wf23-fmfq, CVE-2026-48988
markdown-it
npm
<vulnerable_versions>14.1.1</vulnerable_versions>
<patched_version>14.2.0</patched_version>
<manifest_path>pnpm-lock.yaml</manifest_path>

https://github.com/markdown-it/markdown-it/security/advisories/GHSA-6v5v-wf23-fmfq https://github.com/advisories/GHSA-6v5v-wf23-fmfq

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachabili...

Copilot AI changed the title [WIP] Fix quadratic complexity DoS in markdown-it smartquotes rule Pin markdown-it to 14.2.0 to remediate GHSA-6v5v-wf23-fmfq (CVE-2026-48988) Jun 24, 2026
Copilot AI requested a review from mikeharder June 24, 2026 05:57
@mikeharder mikeharder closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants