Test/get cert coverage

[meilu-git]

No description provided.

[Copilot]

Pull request overview

Expands the TBOR GetCertificate integration test suite in ddi/tbor/types to improve behavioral coverage and cross-check correctness against MBOR and session lifecycle interactions.

Changes:

• Adds DER wire-limit and X.509 parsing validation for certificates returned by TBOR GetCertificate.
• Introduces additional stability and invariance tests (repeat reads, interleaved reads, session-active behavior, reject-path non-mutation).
• Broadens negative-coverage for invalid indices/slots and validates boundaries against GetCertChainInfo.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟢 Approval recommended

The only noted issue is a non-blocking documentation coverage-matrix nit.

Review effort: Lite
Findings: None

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical session-type issue causes tests to fail, and required documentation updates are missing.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1

Open (2)

• Use PlainText session type for CU · New
• Update SPEC_COVERAGE.md for new certificate tests · New

[Copilot]

Copilot review overview

🟡 Changes recommended

Correct coverage references, test totals, and PlainText session descriptions before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 5

Open (5)

• Correct emu test count from 118 to 114 · New
• Correct GetCertificate coverage section name and test paths · New
• Describe test as a CU PlainText session · New
• Label PlainText session accurately in handshake failure · New
• Update SPEC_COVERAGE.md for new certificate tests

Resolved since last review (1)

• Use PlainText session type for CU

[Copilot]

Copilot review overview

🟢 Approval recommended

The only finding is a non-blocking documentation-date nit.

Review effort: Lite
Findings: 1

Open (1)

• Update SPEC_COVERAGE.md for new certificate tests

Resolved since last review (4)

• Label PlainText session accurately in handshake failure
• Describe test as a CU PlainText session
• Correct GetCertificate coverage section name and test paths
• Correct emu test count from 118 to 114

[Copilot]

Copilot review overview

🟡 Changes recommended

The coverage matrix references a non-existent test path and should be corrected.

Review effort: Lite
Findings: 2

Open (2)

• Fix coverage row to reference the existing test name · New
• Update SPEC_COVERAGE.md for new certificate tests

[Copilot]

Copilot review overview

🟢 Approval recommended

Only a minor Markdown formatting nit was identified; no blocking issues remain.

Review effort: Lite
Findings: 1

Open (1)

• Update SPEC_COVERAGE.md for new certificate tests

Resolved since last review (1)

• Fix coverage row to reference the existing test name