-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Container App] az containerapp env: Remove --min-replicas/max-replicas from premium ingress
#32360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request removes unused parameters from the environment premium ingress command functions. The min_replicas and max_replicas parameters were never exposed through the CLI argument parser and therefore could not be used by end users.
- Removed dead code parameters from
add_environment_premium_ingressfunction - Removed dead code parameters from
update_environment_premium_ingressfunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please fix CI issues |
az containerapp env: Remove min/max-replicas from premium ingress
|
@yonzhan the test_functionapp_on_linux_consumption_python_39 test failure is unrelated. |
You can sync dev branch, I checked this |
|
please note that Azure CLI's code completion time is on 11/11/2025 at 07:00 UTC. If you want to catch up this release train, please address the comments and resolve the CI issues asap, otherwise it has to be postponed to next sprint (12/02). |
|
@yanzhudd updated |
|
@Tratcher May I ask if these removed parameters will cause a breaking change for customers? |
|
@zhoxing-ms no, these were accidentally copied from the extension in the last version where they were already marked deprecated. They are inoperative. |
az containerapp env: Remove min/max-replicas from premium ingressaz containerapp env: Remove --min-replicas/max-replicas from premium ingress
Related command
az containerapp env premium-ingress add/update
Description
In the prior PR I missed removing these obsolete parameters when copying over the commands. They are inoperative and were only temporarily available in the preview extension.
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.