Skip to content

Conversation

@Tratcher
Copy link
Contributor

Related command
az containerapp env premium-ingress add/update

Description
In the prior PR I missed removing these obsolete parameters when copying over the commands. They are inoperative and were only temporarily available in the preview extension.

Testing Guide

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings October 31, 2025 17:49
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 31, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 31, 2025

❌AzureCLI-BreakingChangeTest
❌containerapp
rule cmd_name rule_message suggest_message
1007 - ParaRemove containerapp env premium-ingress add cmd containerapp env premium-ingress add removed parameter max_replicas please add back parameter max_replicas for cmd containerapp env premium-ingress add
1007 - ParaRemove containerapp env premium-ingress add cmd containerapp env premium-ingress add removed parameter min_replicas please add back parameter min_replicas for cmd containerapp env premium-ingress add
1007 - ParaRemove containerapp env premium-ingress update cmd containerapp env premium-ingress update removed parameter max_replicas please add back parameter max_replicas for cmd containerapp env premium-ingress update
1007 - ParaRemove containerapp env premium-ingress update cmd containerapp env premium-ingress update removed parameter min_replicas please add back parameter min_replicas for cmd containerapp env premium-ingress update

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 31, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes unused parameters from the environment premium ingress command functions. The min_replicas and max_replicas parameters were never exposed through the CLI argument parser and therefore could not be used by end users.

  • Removed dead code parameters from add_environment_premium_ingress function
  • Removed dead code parameters from update_environment_premium_ingress function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 3, 2025

Please fix CI issues

@Tratcher Tratcher changed the title [Container App] az containerapp env: Remove min/max-replicas from premium ingress [Container App] az containerapp env: Remove min/max-replicas from premium ingress Nov 3, 2025
@Tratcher
Copy link
Contributor Author

Tratcher commented Nov 3, 2025

@yonzhan the test_functionapp_on_linux_consumption_python_39 test failure is unrelated.
I've fixed the title formatting.

@Greedygre
Copy link
Contributor

test_functionapp_on_linux_consumption_python_39

You can sync dev branch, I checked this test_functionapp_on_linux_consumption_python_39 seems has been removed

@yanzhudd
Copy link
Contributor

yanzhudd commented Nov 9, 2025

please note that Azure CLI's code completion time is on 11/11/2025 at 07:00 UTC. If you want to catch up this release train, please address the comments and resolve the CI issues asap, otherwise it has to be postponed to next sprint (12/02).

@Tratcher
Copy link
Contributor Author

@yanzhudd updated

@zhoxing-ms
Copy link
Contributor

@Tratcher May I ask if these removed parameters will cause a breaking change for customers?

@Tratcher
Copy link
Contributor Author

@zhoxing-ms no, these were accidentally copied from the extension in the last version where they were already marked deprecated. They are inoperative.

@yanzhudd yanzhudd changed the title [Container App] az containerapp env: Remove min/max-replicas from premium ingress [Container App] az containerapp env: Remove --min-replicas/max-replicas from premium ingress Nov 10, 2025
@yanzhudd yanzhudd merged commit d52631e into Azure:dev Nov 10, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants