Skip to content

Ensure extension command additions are detected during contract review #10821

Description

Problem

Extension contract reviews can miss a newly exposed command when its registration is added in one changed file and its constructor is implemented elsewhere. Existing guidance required inspecting changed files, but did not make tracing registrations through the command tree an explicit, auditable step.

Fix

Update the contract-review procedure to compare base and head registrations, trace command registrations to constructors and parent commands across files, and track each distinct command-tree change separately. Add regression evals for cross-file registration, multiple independent commands, and a registration refactor that preserves the public command tree.

Relates to #10820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions