Repository navigation
fix: resolve -C/--cwd relative path before extension invocation #8230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Victor Vazquez (vhvb1989)
merged 2 commits into
main
from
ai-agent-init-with-rel-path-issue
May 18, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| "github.com/azure/azure-dev/cli/azd/internal" | ||
| "github.com/azure/azure-dev/cli/azd/pkg/ioc" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestRootCmd_CwdRelativePathResolvedToAbsolute(t *testing.T) { | ||
| // Regression test: a relative -C path must be resolved to an absolute path | ||
| // before os.Chdir so that the AZD_CWD value propagated to extensions doesn't | ||
| // get double-resolved (once by the root command, once by the extension). | ||
| // See https://github.com/Azure/azure-dev/issues/8229 | ||
|
|
||
| tmpDir := t.TempDir() | ||
| t.Chdir(tmpDir) | ||
|
|
||
| relDir := "mySubFolder" | ||
| absExpected := filepath.Join(tmpDir, relDir) | ||
|
|
||
| container := ioc.NewNestedContainer(nil) | ||
| opts := &internal.GlobalCommandOptions{ | ||
| Cwd: relDir, | ||
| NoPrompt: true, | ||
| } | ||
| ioc.RegisterInstance(container, opts) | ||
|
|
||
| rootCmd := NewRootCmd(false, nil, container) | ||
|
|
||
| // Add a no-op subcommand so cobra has something to run | ||
| rootCmd.SetArgs([]string{"version"}) | ||
| rootCmd.SetContext(t.Context()) | ||
|
|
||
| // PersistentPreRunE triggers on Execute | ||
| err := rootCmd.Execute() | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, absExpected, opts.Cwd, | ||
| "relative -C path should be resolved to absolute before chdir") | ||
|
vhvb1989 marked this conversation as resolved.
Resolved
|
||
|
|
||
| // Verify the cobra flag was also updated | ||
| f := rootCmd.PersistentFlags().Lookup("cwd") | ||
| require.NotNil(t, f) | ||
| require.Equal(t, absExpected, f.Value.String(), | ||
| "cobra cwd flag should be updated to absolute path") | ||
|
|
||
| // Note: process CWD is restored by PersistentPostRunE, so we don't check it here. | ||
| // The important thing is that opts.Cwd and the cobra flag hold the absolute path, | ||
| // which is what gets propagated to extensions as AZD_CWD. | ||
| } | ||
|
|
||
| func TestRootCmd_CwdAbsolutePathUnchanged(t *testing.T) { | ||
| // Absolute paths should pass through unchanged. | ||
|
|
||
| tmpDir := t.TempDir() | ||
| subDir := filepath.Join(tmpDir, "absTest") | ||
| require.NoError(t, os.MkdirAll(subDir, 0755)) | ||
|
|
||
| container := ioc.NewNestedContainer(nil) | ||
| opts := &internal.GlobalCommandOptions{ | ||
| Cwd: subDir, | ||
| NoPrompt: true, | ||
| } | ||
| ioc.RegisterInstance(container, opts) | ||
|
|
||
| rootCmd := NewRootCmd(false, nil, container) | ||
| rootCmd.SetArgs([]string{"version"}) | ||
| rootCmd.SetContext(t.Context()) | ||
|
|
||
| err := rootCmd.Execute() | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, subDir, opts.Cwd, | ||
| "absolute path should remain unchanged") | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.