Skip to content

Conversation

@parthshah2305
Copy link
Member

@parthshah2305 parthshah2305 commented Nov 5, 2025

  • Adding shared compute limit RP API specs

  • adding emitter-output-dir


ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

* Adding shared compute limit RP API specs

* adding emitter-output-dir

---------

Co-authored-by: Parth Shah <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.ComputeLimit-ComputeLimit
TypeSpec Microsoft.ComputeLimit
Go sdk/resourcemanager/computelimit/armcomputelimit
Python azure-mgmt-computelimit
C# Azure.ResourceManager.ComputeLimit
JavaScript @azure/arm-computelimit
Java com.azure.resourcemanager:azure-resourcemanager-computelimit

@parthshah2305
Copy link
Member Author

@gary-x-li As discussed in the ARM office hours today, we are a Ring 0 service and have gotten an exception from onboarding to RPSaaS from Evan Hissey and Vikash Jain. Microsoft.ComputeLimit would be a direct RP. Can you get an exception from merging to the RPSaaSMaster branch?

image

@parthshah2305 parthshah2305 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Nov 6, 2025
@github-actions github-actions bot added NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 6, 2025
@parthshah2305
Copy link
Member Author

Earlier PR review for the release branch - #38491

@gary-x-li gary-x-li added RPaaSException https://github.com/Azure/azure-sdk-tools/issues/5311#issue-1567009479 and removed CI-RpaaSRPNotInPrivateRepo NotReadyForARMReview labels Nov 6, 2025
@parthshah2305 parthshah2305 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed NotReadyForARMReview labels Nov 6, 2025
@gary-x-li gary-x-li added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed NotReadyForARMReview labels Nov 6, 2025
@github-actions github-actions bot added NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Nov 6, 2025
@mikeharder mikeharder added PipelineBotTrigger ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Nov 6, 2025
@github-actions github-actions bot removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 6, 2025
@mikeharder mikeharder removed the RPaaSException https://github.com/Azure/azure-sdk-tools/issues/5311#issue-1567009479 label Nov 6, 2025
@mikeharder mikeharder added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review RPaaSException https://github.com/Azure/azure-sdk-tools/issues/5311#issue-1567009479 labels Nov 6, 2025
@github-actions github-actions bot removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 6, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Nov 7, 2025
@mikeharder mikeharder added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 7, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 7, 2025
@hbh101 hbh101 self-assigned this Nov 10, 2025
@parthshah2305 parthshah2305 merged commit 183c0a5 into main Nov 10, 2025
165 of 167 checks passed
@parthshah2305 parthshah2305 deleted the release-quotaservice-computelimit-2025_08_15 branch November 10, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-NewRPNamespaceWithoutRPaaS new-api-version new-rp-namespace PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaSException https://github.com/Azure/azure-sdk-tools/issues/5311#issue-1567009479 TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants