-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Refactor(keyvault): migrate to unified folder structure #38668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
v-xuto
wants to merge
15
commits into
Azure:main
Choose a base branch
from
v-xuto:keyvault-folder-structure-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
2a1cc1a to
a4a5463
Compare
def0dd5 to
9f7121e
Compare
9f7121e to
c6f19df
Compare
1a42501 to
142bb43
Compare
c9b958e to
9635926
Compare
9635926 to
ab3cae9
Compare
chlowell
requested changes
Nov 13, 2025
Member
chlowell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SDK team is still discussing whether and how to refactor these projects
c38379b to
9b81b00
Compare
9b81b00 to
1712696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-Avocado
Approved-LintDiff
Approved-Suppression
ARMReview
BreakingChange-Approved-Benign
Changes are not breaking at the REST API level and have at most minor impact to generated SDKs.
BreakingChange-JavaScript-Sdk
BreakingChange-JavaScript-Sdk-Approved
BreakingChange-Python-Sdk
BreakingChange-Python-Sdk-Approved
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
CI-NewRPNamespaceWithoutRPaaS
data-plane
FolderMigrationV2
A specific label for PRs like folder structure migration into v2.
KeyVault
new-api-version
new-rp-namespace
NotReadyForARMReview
resource-manager
SuppressionReviewRequired
TypeSpec
Authored with TypeSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the keyvault specification to the new unified folder structure according to Azure folder structure guidelines.
Change:
tspconfig.yamlwith correct paths and ARM types directoryreadme.mdsuppressions.yamlfor legacy API versionsspecification/suppressions.yamlfilecspell.yamlfileBenefits: