Skip to content

Conversation

@v-xuto
Copy link
Member

@v-xuto v-xuto commented Nov 7, 2025

This PR migrates the keyvault specification to the new unified folder structure according to Azure folder structure guidelines.

Change:

  • Consolidated TypeSpec and Swagger files under
├── data-plane                   
│   ├── Administration            
│   │   ├── BackupRestore
│   │   ├── RBAC
│   │   └── Settings   
│   ├── Certificates             
│   ├── Keys                     
│   ├── Secrets                   
│   ├── SecretsStorage            
│   ├── SecurityDomain            
│   └── Legacy       # Old api versions
│
└── resource-manager/Microsoft.KeyVault/KeyVault          
  • Updated tspconfig.yaml with correct paths and ARM types directory
  • Fixed all common-types references and input-file paths in readme.md
  • Added suppressions.yaml for legacy API versions
  • Verified TypeSpec compilation works correctly
  • Updated the relevant paths in specification/suppressions.yaml file
  • Updated the relevant paths in cspell.yaml file

Benefits:

  • Unified structure for better maintainability
  • Aligns with Azure folder structure standards
  • Maintains backward compatibility
  • Supports future TypeSpec migration efforts

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ Your PR requires an API stewardship board review as it introduces a new API version (label: new-api-version). Schedule the review by following aka.ms/azsdk/onboarding/restapischedule.
  • ❌ This PR is NotReadyForARMReview because it has the CI-NewRPNamespaceWithoutRPaaS label.
  • ❌ This PR has CI-NewRPNamespaceWithoutRPaaS label. This means it is introducing a new RP (Resource Provider) namespace that has not been onboarded with RPaaS. Merging this PR to the main branch is blocked as RPaaS is required for new RPs.
    To resolve, use RPaaS to onboard the new RP. To apply for exception, see aka.ms/RPaaSException.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@v-xuto v-xuto added the FolderMigrationV2 A specific label for PRs like folder structure migration into v2. label Nov 7, 2025
@github-actions github-actions bot added BreakingChange-Go-Sdk BreakingChange-Python-Sdk BreakingChange-JavaScript-Sdk BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec KeyVault
TypeSpec Microsoft.KeyVault
Swagger Administration-Certificates
Swagger Administration-Keys
Swagger Administration-Legacy
Swagger Administration-Secrets
Swagger Administration-SecretsStorage
Swagger Administration-SecurityDomain
Swagger Microsoft.KeyVault-KeyVault
Swagger Administration-Administration
JavaScript @azure/keyvault-admin
JavaScript @azure/keyvault-certificates
JavaScript @azure/keyvault-keys
JavaScript @azure/keyvault-secrets
JavaScript @azure/arm-keyvault
Python azure-keyvault-administration
Python azure-keyvault-certificates
Python azure-keyvault-keys
Python azure-keyvault-secrets
Python azure-mgmt-keyvault

@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch from 2a1cc1a to a4a5463 Compare November 10, 2025 06:33
@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch 5 times, most recently from def0dd5 to 9f7121e Compare November 12, 2025 09:33
@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch from 9f7121e to c6f19df Compare November 13, 2025 05:46
@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch from 1a42501 to 142bb43 Compare November 13, 2025 06:40
@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch 3 times, most recently from c9b958e to 9635926 Compare November 13, 2025 10:25
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK team is still discussing whether and how to refactor these projects

@tadelesh tadelesh force-pushed the keyvault-folder-structure-refactor branch from c38379b to 9b81b00 Compare November 17, 2025 07:03
@tadelesh tadelesh force-pushed the keyvault-folder-structure-refactor branch from 9b81b00 to 1712696 Compare November 17, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants